Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyCGM_Single/pycgmClusters.py imports and uses a non-existent function #24

Open
niravkin opened this issue Oct 5, 2020 · 2 comments
Open

pyCGM_Single/pycgmClusters.py imports and uses a non-existent function #24

niravkin opened this issue Oct 5, 2020 · 2 comments
Assignees
@niravkin
Labels
bug-light A bug that hasn't caused problems but could later on hold Not working on, or will be resolved later

Comments

@niravkin
Copy link
Contributor

niravkin commented Oct 5, 2020

The file pycgmClusters.py contains one function, calcFramesClusters which imports a function from clusterCalc.py named groupInClustDict that does not exist.

On line 15, the function is imported:
from .clusterCalc import targetName, getMarkerLocation, targetDict, groupInClustDict ,getStaticTransform

On line 18, the function is used:
clusters = groupInClustDict()
@niravkin niravkin changed the title pycgmClusters.py imports and uses a non-existent function pyCGM_Single/pycgmClusters.py imports and uses a non-existent function Oct 5, 2020
@niravkin
Copy link
Contributor Author

niravkin commented Oct 5, 2020

clusterCalc.py is also imported in Pipelines.py, but only using existing functions:
from .clusterCalc import targetName,getMarkerLocation,segment_dict,target_dict,getStaticTransform

@cadop cadop added the bug-light A bug that hasn't caused problems but could later label Oct 12, 2020
@cadop
Copy link
Owner

cadop commented Oct 31, 2020

@niravkin What was the resolution here?

@cadop cadop added the on hold Not working on, or will be resolved later label Oct 31, 2020
GVeras pushed a commit to GVeras/pyCGM that referenced this issue Dec 5, 2020
@moppr
Merge pull request cadop#24 from thepeytongreen/refactor-3
b8433ca 
Adding unit tests for shoulder_axis_calc, elbow_axis_calc, wand_marker, point_to_line, and find_l5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niravkin niravkin

Labels
bug-light A bug that hasn't caused problems but could later on hold Not working on, or will be resolved later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cadop @niravkin