Raise ValueError on save without filename

Author: ronald-jaepel

cadet/h5.py

@@ -136,7 +136,7 @@ def save(self, lock: bool = False) -> None:
                 with h5py.File(self.filename, 'w') as h5file:
                     recursively_save(h5file, '/', self.root, self.transform)
         else:
-            print("Filename must be set before save can be used")
+            raise ValueError("Filename must be set before save can be used")
 
     def save_json(self, filename: str | Path) -> None:
         """

tests/test_h5.py

@@ -164,9 +164,9 @@ def test_load_nonexistent_file():
         instance.load()
 
 
-# def test_save_without_filename(h5_instance):
-#     with pytest.raises(ValueError):
-#         h5_instance.save()
+def test_save_without_filename(h5_instance):
+    with pytest.raises(ValueError):
+        h5_instance.save()
 
 
 def test_load_json_with_invalid_data(temp_json_file):