bug fix on get auto config hint

Author: shijiesheng

internal/internal_worker_base.go

@@ -425,12 +425,12 @@ func (bw *baseWorker) Stop() {
 
 func getAutoConfigHint(task interface{}) *shared.AutoConfigHint {
 	switch t := task.(type) {
-	case workflowTask:
+	case *workflowTask:
 		if t.task == nil {
 			return nil
 		}
 		return t.task.AutoConfigHint
-	case activityTask:
+	case *activityTask:
 		if t.task == nil {
 			return nil
 		}

internal/internal_worker_test.go

@@ -1498,3 +1498,39 @@ func TestTestValidateFnFormat_Workflow(t *testing.T) {
 		})
 	}
 }
+
+func TestGetTaskAutoConfigHint(t *testing.T) {
+
+	hint := shared.AutoConfigHint{
+		EnableAutoConfig:   common.BoolPtr(true),
+		PollerWaitTimeInMs: common.Int64Ptr(100),
+	}
+
+	for _, tt := range []struct {
+		name string
+		task interface{}
+		want *shared.AutoConfigHint
+	}{
+		{
+			"decision task",
+			&workflowTask{
+				&shared.PollForDecisionTaskResponse{AutoConfigHint: &hint}, nil, nil, nil},
+			&hint,
+		},
+		{
+			"activity task",
+			&activityTask{
+				&shared.PollForActivityTaskResponse{AutoConfigHint: &hint}, time.Now()},
+			&hint,
+		},
+		{
+			"localactivity task",
+			&localActivityTask{},
+			nil,
+		},
+	} {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.want, getAutoConfigHint(tt.task))
+		})
+	}
+}

internal/worker/concurrency_auto_scaler.go

@@ -34,7 +34,7 @@ import (
 )
 
 const (
-	defaultAutoScalerUpdateTick = time.Second
+	defaultAutoScalerUpdateTick   = time.Second
 	targetPollerWaitTimeInMsLog2  = 4 // 16 ms
 	numberOfPollsInRollingAverage = 20
 
@@ -50,9 +50,9 @@ const (
 	autoScalerEventLogMsg                     string          = "concurrency auto scaler event"
 	testTimeFormat                            string          = "15:04:05"
 
-	metricsEnabled = "enabled"
-	metricsDisabled = "disabled"
-	metricsPollerQuota = "poller-quota"
+	metricsEnabled        = "enabled"
+	metricsDisabled       = "disabled"
+	metricsPollerQuota    = "poller-quota"
 	metricsPollerWaitTime = "poller-wait-time"
 )
 
@@ -69,14 +69,14 @@ type (
 		updateTick  time.Duration
 
 		// state of autoscaler
-		lock sync.RWMutex
+		lock    sync.RWMutex
 		enabled bool
 
 		// poller
 		pollerInitCount        int
 		pollerMaxCount         int
 		pollerMinCount         int
-		pollerWaitTime  *rollingAverage[time.Duration]
+		pollerWaitTime         *rollingAverage[time.Duration]
 		pollerPermitLastUpdate time.Time
 	}
 
@@ -111,7 +111,7 @@ func NewConcurrencyAutoScaler(input ConcurrencyAutoScalerInput) *ConcurrencyAuto
 		pollerInitCount:        input.Concurrency.PollerPermit.Quota(),
 		pollerMaxCount:         input.PollerMaxCount,
 		pollerMinCount:         input.PollerMinCount,
-		pollerWaitTime: newRollingAverage[time.Duration](numberOfPollsInRollingAverage),
+		pollerWaitTime:         newRollingAverage[time.Duration](numberOfPollsInRollingAverage),
 		pollerPermitLastUpdate: input.Clock.Now(),
 	}
 }
@@ -157,7 +157,7 @@ func (c *ConcurrencyAutoScaler) ProcessPollerHint(hint *shared.AutoConfigHint) {
 	}
 	if hint.PollerWaitTimeInMs != nil {
 		waitTimeInMs := *hint.PollerWaitTimeInMs
-		c.pollerWaitTime.Add(time.Millisecond*time.Duration(waitTimeInMs))
+		c.pollerWaitTime.Add(time.Millisecond * time.Duration(waitTimeInMs))
 	}
 
 	var shouldEnable bool
@@ -209,7 +209,7 @@ func (c *ConcurrencyAutoScaler) updatePollerPermit() {
 	currentQuota := c.concurrency.PollerPermit.Quota()
 	// smoothing the scaling through log2
 	newQuota := int(math.Round(float64(currentQuota) * targetPollerWaitTimeInMsLog2 / math.Log2(
-		1+float64(c.pollerWaitTime.Average()/time.Millisecond)) ))
+		1+float64(c.pollerWaitTime.Average()/time.Millisecond))))
 	if newQuota < c.pollerMinCount {
 		newQuota = c.pollerMinCount
 	}