Merge pull request #274 from Niols/checkmake

Add hook for `checkmake`

Author: domenkozar

README.md

@@ -202,6 +202,7 @@ use nix
 - [tagref](https://github.com/stepchowfun/tagref)
 - [treefmt](https://github.com/numtide/treefmt)
 - [topiary](https://github.com/tweag/topiary)
+- [checkmake](https://github.com/mrtazz/checkmake)
 
 You must configure which languages should be formatted by `clang_format` using
 `clang-format.types_or`. For example to check both C and C++ files:

flake.lock

@@ -1167,5 +1167,18 @@ in
           pass_filenames = true;
           entry = "${settings.treefmt.package}/bin/treefmt --fail-on-change";
         };
+
+      checkmake = {
+        name = "checkmake";
+        description = "Experimental linter/analyzer for Makefiles.";
+        types = [ "makefile" ];
+        entry =
+          ## NOTE: `checkmake` 0.2.2 landed in nixpkgs on 12 April 2023. Once
+          ## this gets into a NixOS release, the following code will be useless.
+          lib.throwIf
+            (tools.checkmake == null)
+            "The version of nixpkgs used by pre-commit-hooks.nix must have `checkmake` in version at least 0.2.2 for it to work on non-Linux systems."
+            "${tools.checkmake}/bin/checkmake";
+      };
     };
 }

modules/hooks.nix

@@ -1,10 +1,13 @@
-{ actionlint
+{ stdenv
+
+, actionlint
 , alejandra
 , ansible-lint
 , cabal-fmt
 , cabal2nix
 , callPackage
 , cargo
+, checkmake
 , clang-tools
 , clippy
 , commitizen
@@ -81,4 +84,8 @@ in
   chktex = tex;
   commitizen = commitizen.overrideAttrs (_: _: { doCheck = false; });
   bats = if bats ? withLibraries then (bats.withLibraries (p: [ p.bats-support p.bats-assert p.bats-file ])) else bats;
+
+  ## NOTE: `checkmake` 0.2.2 landed in nixpkgs on 12 April 2023. Once this gets
+  ## into a NixOS release, the following code will be useless.
+  checkmake = if stdenv.isLinux || checkmake.version >= "0.2.2" then checkmake else null;
 }