Skip to content

Rename Rustify/Aliases.hpp to Common.hpp #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ken-matsui opened this issue Oct 13, 2024 · 2 comments · Fixed by #1117
Closed

Rename Rustify/Aliases.hpp to Common.hpp #1027

ken-matsui opened this issue Oct 13, 2024 · 2 comments · Fixed by #1117
Labels
good first issue Good for newcomers

Comments

@ken-matsui
Copy link
Member

After #1025, Rustify/Aliases.hpp does not basically represent aliases or Rusty things (_path and string literals are not related). Renaming it to Common.hpp makes more sense now.
@ken-matsui ken-matsui added the good first issue Good for newcomers label Oct 13, 2024
@wow2006 wow2006 mentioned this issue Dec 19, 2024
Closed
@wow2006
Copy link

wow2006 commented Dec 19, 2024

I created a PR for that #1047

ken-matsui added a commit that referenced this issue Jan 22, 2025
@ken-matsui
Aliases: removed
625a015 
resolves #1027
@ken-matsui ken-matsui mentioned this issue Jan 22, 2025
Merged
@ken-matsui
Copy link
Member Author

Unfortunately, I decided to remove the file. Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aliases: removed cabinpkg/cabin
2 participants
@wow2006 @ken-matsui