fix(core): async return instruction usage #1414
Merged
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
fix(core)=return-instruction-amt
branch
5 times, most recently
from
9928b44 to
84b2d2a
Compare
This commit fixes a few issues in the async return machinery: 1. `Instruction::Return` calculation of `amt` for functions with no return values 2. Missing use of `Instruction::AsyncTaskReturn` 3. Determination of whether to pass a pointer or flat params for async functions Both issues were in the function with no result case: For (1), the code did not take into account that the async functions *always* return at least the async state (a single i64). For (2), the code did not use an `Instruction::AsyncTaskReturn`, rather than a regular `Instruction::Return` For (3), the code did not take into account whether the number of results was lower than the max flattened values or not
vados-cosmonic
force-pushed
the
fix(core)=return-instruction-amt
branch
from
84b2d2a to
07300a8
Compare
alexcrichton
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a few issues in the async return machinery:
Instruction::Returncalculation ofamtfor functions with noreturn values
Missing use of
Instruction::AsyncTaskReturnDetermination of whether to pass a pointer or flat params for async functions
Both issues were in the function with no result case:
For (1), the code did not take into account that the async
functions always return at least the async state (a single i64).
For (2), the code did not use an
Instruction::AsyncTaskReturn, ratherthan a regular
Instruction::ReturnFor (3), the code did not take into account whether the number of
results was lower than the max flattened values or not