Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[^2] and [^3] not working to resolve footnotes #14

Open
bjhess opened this issue Dec 17, 2024 · 4 comments
Open

[^2] and [^3] not working to resolve footnotes #14

bjhess opened this issue Dec 17, 2024 · 4 comments

Comments

@bjhess
Copy link

bjhess commented Dec 17, 2024

I've been working on bringing this extension to Pika and noticed this odd behavior that I think is conflicting with Tiptap itself.

The tiptap-footnotes extension doesn't seem to be able to handle [^2] or [^3]. Here's Buttondown:

CleanShot 2024-12-17 at 16 48 38

So I went over to the Tiptap editor itself and found that Tiptap is specifically processing ^2 or ^3 into superscripts, leading to a conflict that gets in the way of tiptap-footnotes:

CleanShot 2024-12-17 at 16 45 08

I haven't been able to find any docs that suggest Tiptap should be behaving this way. I have reached out to them on Discord to see if I can find more information.

Copy link

linear bot commented Dec 17, 2024

@bjhess bjhess changed the title Tabbing broken in "editing" context [^2] and [^3] not working to resolve footnotes Dec 17, 2024
@jmduke
Copy link
Member

jmduke commented Dec 18, 2024

oh wow. I think this is part of Typography: https://tiptap.dev/docs/editor/extensions/functionality/typography

image

Can you try disabling those rules on your end and confirming it fixes the behavior? (We should, if so, do the same on Buttondown!)

@bjhess
Copy link
Author

bjhess commented Dec 18, 2024

Yes! This does it:

Typography.configure({
  superscriptTwo: false,
  superscriptThree: false,
}),

@jmduke
Copy link
Member

jmduke commented Dec 19, 2024

Cool! In that case, I think all we should do here is file this in docs (and of course fix on Buttondown's side — cc @mary-ext) since this seems like correct behavior, just.. obtuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants