Fixing robocop issues, extending travis build with pin commands

Author: ondrejfuhrer

.travis.yml

@@ -3,9 +3,7 @@ language: ruby
 os: osx
 
 rvm:
-  # - 2.5
   - 2.6
-  # - 2.7
 
 before_install:
   - brew update
@@ -21,4 +19,8 @@ script:
   - cd /usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade
   - rubocop --version
   - rubocop
+  - brew cu pin java
+  - brew cu pinned
+  - brew cu -y --no-brew-update
+  - brew cu unpin java
   - brew cu -y --no-brew-update

lib/bcu/command/pin_list.rb

@@ -21,7 +21,7 @@ def list_pinned(_args, _options)
       def add_cask(cask_name, casks)
         casks.push Cask.load_cask(cask_name)
       rescue Cask::CaskUnavailableError
-        Bcu::Pin::Remove.remove_pin cask:cask_name
+        Bcu::Pin::Remove.remove_pin cask: cask_name
       end
     end
   end

lib/bcu/command/pin_remove.rb

@@ -8,7 +8,7 @@ def process(args, options)
         # TODO: If we used deprecated --pin option, the value is not any more in the args
         pin = options.unpin if pin.nil?
 
-        remove_pin cask:pin
+        remove_pin cask: pin
       end
 
       private

lib/bcu/command/upgrade.rb

@@ -113,9 +113,7 @@ def find_outdated_apps(installed, options)
           found
         end
 
-        if installed.empty?
-          odie empty_message(options.casks)
-        end
+        odie empty_message(options.casks) if installed.empty?
       end
 
       installed.each do |app|

lib/bcu/options.rb

@@ -119,12 +119,9 @@ def self.validate_options(options)
     end
   end
 
-  def self.build_config(use_config_file = true)
-    if use_config_file
-      options = load_default_options
-    else
-      options = create_default_options
-    end
+  def self.build_config(use_config_file: true)
+    options = use_config_file ? load_default_options : create_default_options
+
     options.casks = nil
     options.install_options = ""
     options.list_pinned = false
@@ -145,10 +142,12 @@ def self.load_default_options
     default_options = create_default_options
     if File.exist?(config_filename)
       odebug "Loading configuration from config file"
-      handle = File.open(config_filename)
-      options = YAML::load handle.read
-      odebug "Configuration loaded", options
-      OpenStruct.new(options.to_h)
+      options = {}
+      File.open(config_filename) do |f|
+        options = (YAML.safe_load f.read).to_h
+        odebug "Configuration loaded", options
+      end
+      OpenStruct.new options
     else
       # something went wrong while reading config file
       odebug "Config file wasn't created, setting default config"
@@ -172,27 +171,26 @@ def self.create_default_options
   end
 
   def self.create_default_config_file(config_filename)
-    begin
-      system "touch #{config_filename}"
-      handle = File.open(config_filename, "w")
-      handle.write default_config_hash.to_yaml
-      handle.close
-    rescue Exception => e
-      odebug "RESCUE: File couldn't be created", e
-      system "rm -f #{config_filename}"
+    File.unlink config_filename
+    system "touch #{config_filename}"
+    File.open(config_filename, "w") do |f|
+      f.write default_config_hash.to_yaml
     end
+  rescue => e
+    odebug "RESCUE: File couldn't be created", e
+    system "rm -f #{config_filename}"
   end
 
   def self.default_config_hash
     {
-        "all" => false,
-        "force" => false,
-        "cleanup" => false,
-        "force_yes" => false,
-        "no_brew_update" => false,
-        "quiet" => false,
-        "verbose" => false,
-        "interactive" => false,
+      "all"            => false,
+      "force"          => false,
+      "cleanup"        => false,
+      "force_yes"      => false,
+      "no_brew_update" => false,
+      "quiet"          => false,
+      "verbose"        => false,
+      "interactive"    => false,
     }
   end
 end

lib/extend/cask.rb

@@ -1,6 +1,6 @@
 # For backward-compatibility
 # See https://github.com/buo/homebrew-cask-upgrade/issues/97
-CASKROOM = Cask.methods.include?(:caskroom) ? Cask.caskroom.freeze : Cask::Caskroom.path.freeze
+CASKROOM = (Cask.methods.include?(:caskroom) ? Cask.caskroom : Cask::Caskroom.path).freeze
 
 module Cask
   def self.installed_apps