Skip to content

Commit b5290b9

Browse files
authored
Merge pull request #111 from bufferoverflow/docs/minor-fixes
Docs/minor fixes
2 parents 0c4b2d1 + a66fb59 commit b5290b9

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

README.md

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,13 @@ packages:
5252
'@*/*':
5353
# scoped packages
5454
access: $all
55-
publish: $authenticated
55+
publish: $maintainer
5656
proxy: npmjs
5757
gitlab: true
5858

5959
'**':
6060
access: $all
61-
publish: $authenticated
61+
publish: $maintainer
6262
proxy: npmjs
6363
gitlab: true
6464

@@ -102,7 +102,7 @@ directives:
102102
- unauthenticated users will be able to access packages marked with either
103103
`$all` or `$anonymous` access levels at the package group definition
104104

105-
Please note that no group or package name mapping is applied on access, any
105+
> *Please note* that no group or package name mapping is applied on access, any
106106
user successfully authenticated can access all packages.
107107

108108
### Publish
@@ -181,7 +181,7 @@ internal timer that will check expired values regularly, so data of
181181
users not actively interacting with the system will also be eventually
182182
invalidated.
183183

184-
*Please note* that this implementation is in-memory and not
184+
> *Please note* that this implementation is in-memory and not
185185
multi-process; if the cluster module is used for starting several
186186
verdaccio processes, each process will store its own copy of the cache,
187187
so each user will actually be logged in multiple times.
@@ -206,7 +206,19 @@ on docker startup with the `--volume` option, or equivalent mechanism
206206
(e.g. ConfigMaps on Kubernetes / OpenShift with the
207207
[helm chart](https://github.com/helm/charts/tree/master/stable/verdaccio)).
208208

209-
## Create a Release
209+
## Development
210+
211+
### Contributing
212+
213+
Please adhere to the [verdaccio community guidelines](https://github.com/verdaccio/verdaccio/blob/master/CONTRIBUTING.md)
214+
and run all the tests before creating a PR. The commit message shall follow the
215+
conventional changelog as it is enforced via local commit hook using husky and
216+
the [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint)
217+
rule set.
218+
219+
> PR's that do not pass CI will not be reviewed.
220+
221+
### Create a Release
210222

211223
Run one of the following command to create a release:
212224

@@ -222,7 +234,7 @@ finally run
222234
yarn publish
223235
```
224236

225-
## Functional Tests
237+
### Functional Tests
226238

227239
In order to run functional tests with debug output, set the
228240
`VERDACCIO_DEBUG=true` environment variable,
@@ -232,12 +244,6 @@ In order to run functional tests with debug output, set the
232244
VERDACCIO_DEBUG=true yarn test:functional
233245
```
234246

235-
## Inspired by
236-
237-
- [verdaccio-ldap](https://github.com/Alexandre-io/verdaccio-ldap)
238-
- [node-bacstack](https://github.com/fh1ch/node-bacstack)
239-
- [verdaccio-bitbucket](https://github.com/idangozlan/verdaccio-bitbucket)
240-
241247
## License
242248

243249
[MIT](https://spdx.org/licenses/MIT)

0 commit comments

Comments
 (0)