Skip to content

Commit e89468c

Browse files
committed
Fix test for ShouldVersionFile
1 parent d6321df commit e89468c

File tree

1 file changed

+16
-19
lines changed

1 file changed

+16
-19
lines changed

main_test.go

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
package main
22

33
import (
4-
"os"
54
"fmt"
5+
"os"
66
"testing"
7+
78
"github.com/spf13/afero"
89
)
910

@@ -25,22 +26,18 @@ func TestGetFileURL(t *testing.T) {
2526
}
2627
}
2728

28-
2929
func TestShouldVersionFile(t *testing.T) {
3030
tests := []struct {
31-
filename string
32-
skipVersioning bool
33-
expected bool
34-
} {
35-
{ "bundle.js", false, true },
36-
{ "bundle.js", true, false },
37-
{ "assets.css", false, true },
38-
{ "assets.css", true, false },
39-
{ "another.file", false, false },
31+
filename string
32+
expected bool
33+
}{
34+
{"bundle.js", true},
35+
{"assets.css", true},
36+
{"another.file", false},
4037
}
4138

4239
for _, test := range tests {
43-
actual := ShouldVersionFile(test.filename, test.skipVersioning)
40+
actual := ShouldVersionFile(test.filename)
4441
if actual != test.expected {
4542
t.Errorf("ShouldVersionFile result was incorrect, got %t, expected %t for filename %s", actual, test.expected, test.filename)
4643
}
@@ -53,13 +50,13 @@ func TestGetUploadFilename(t *testing.T) {
5350
file, _ := AppFs.OpenFile(filename, os.O_CREATE, 0600)
5451
file.WriteString("some JS content")
5552
tests := []struct {
56-
file afero.File
57-
filename string
53+
file afero.File
54+
filename string
5855
skipVersioning bool
59-
expected string
60-
} {
61-
{ file, filename, false, "bundle.d41d8cd98f00b204e9800998ecf8427e.js" },
62-
{ file, filename, true, "bundle.js" },
56+
expected string
57+
}{
58+
{file, filename, false, "bundle.d41d8cd98f00b204e9800998ecf8427e.js"},
59+
{file, filename, true, "bundle.js"},
6360
}
6461

6562
for _, test := range tests {
@@ -69,4 +66,4 @@ func TestGetUploadFilename(t *testing.T) {
6966
t.Errorf("GetUploadFilename result was incorrect, got %s, expected %s", actual, test.expected)
7067
}
7168
}
72-
}
69+
}

0 commit comments

Comments
 (0)