Skip to content

Commit 5bbf2bf

Browse files
Fixes for strict conformance with Editions (#226)
I accidentally did not test with the `--strict*` flags set and left a couple of copy-paste errors :( Oops! This should now pass as expected with updated implementations.
1 parent bb1d618 commit 5bbf2bf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/protovalidate-conformance/internal/cases/cases_ignore_empty.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ func ignoreEmptySuite() suites.Suite {
306306
},
307307
"proto/2023/message/explicit_presence/length_prefixed/zero": suites.Case{
308308
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresence{Val: &cases.IgnoreEmptyEditionsMessageExplicitPresence_Msg{}},
309-
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.proto2.message"}),
309+
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.editions.message"}),
310310
},
311311
"proto/2023/message/explicit_presence/length_prefixed/unset": suites.Case{
312312
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresence{},
@@ -318,7 +318,7 @@ func ignoreEmptySuite() suites.Suite {
318318
},
319319
"proto/2023/message/explicit_presence/delimited/zero": suites.Case{
320320
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited{Val: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited_Msg{}},
321-
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.proto2.message"}),
321+
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.editions.message"}),
322322
},
323323
"proto/2023/message/explicit_presence/delimited/unset": suites.Case{
324324
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited{},

0 commit comments

Comments
 (0)