Skip to content

Commit 65bcc92

Browse files
authored
Merge pull request jdorn#717 from kameelyan/master
Add allOf to existing validation ignore and add .vs into gitignore
2 parents cfec910 + c8a8bac commit 65bcc92

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@
88
.env
99
/src/themes/*.css.js
1010
/src/editors/*.css.js
11+
/.vs

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
- Cleaned how default themes, iconlibs, editors and templates are imported to JSONEditor
1313
- Added ability to attache editors and themes style rules to the shadowRoot if the editor is inside a Web Component.
1414
- Fix of #701 - editors/number.js and editors/integer.js don't change values when validation is failed
15+
- Fix of #716 - add ignore for allOf to fall in line with existing ignores of anyOf/oneOf for additionalProperties validation
1516

1617
### 2.0.0-dev
1718
- Fix of #643 - Allow use of themes not compiled directly into the build

src/validator.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,8 +575,8 @@ export class Validator {
575575
}
576576
})
577577

578-
/* The no_additional_properties option currently doesn't work with extended schemas that use oneOf or anyOf */
579-
if (typeof schema.additionalProperties === 'undefined' && this.jsoneditor.options.no_additional_properties && !schema.oneOf && !schema.anyOf) {
578+
/* The no_additional_properties option currently doesn't work with extended schemas that use oneOf or anyOf or allOf */
579+
if (typeof schema.additionalProperties === 'undefined' && this.jsoneditor.options.no_additional_properties && !schema.oneOf && !schema.anyOf && !schema.allOf) {
580580
schema.additionalProperties = false
581581
}
582582

0 commit comments

Comments
 (0)