Skip to content

Commit ac1a183

Browse files
committed
Test newer versions using supported Node, without embroider
1 parent c57ff04 commit ac1a183

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.travis.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ language: node_js
33
node_js:
44
# we recommend testing addons with the same minimum supported node version as Ember CLI
55
# so that your addon works for all apps
6-
- "10"
6+
- "12"
77

88
dist: xenial
99

@@ -46,15 +46,15 @@ jobs:
4646

4747
# we recommend new addons test the current and previous LTS
4848
# as well as latest stable release (bonus points to beta/canary)
49-
- env: EMBER_TRY_SCENARIO=ember-lts-3.16
5049
- env: EMBER_TRY_SCENARIO=ember-lts-3.20
50+
- env: EMBER_TRY_SCENARIO=ember-lts-3.24
5151
- env: EMBER_TRY_SCENARIO=ember-release
5252
- env: EMBER_TRY_SCENARIO=ember-beta
5353
- env: EMBER_TRY_SCENARIO=ember-canary
5454
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
5555
- env: EMBER_TRY_SCENARIO=ember-classic
56-
- env: EMBER_TRY_SCENARIO=embroider-safe
57-
- env: EMBER_TRY_SCENARIO=embroider-optimized
56+
# - env: EMBER_TRY_SCENARIO=embroider-safe
57+
# - env: EMBER_TRY_SCENARIO=embroider-optimized
5858

5959
before_install:
6060
- curl -o- -L https://yarnpkg.com/install.sh | bash

config/ember-try.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@ module.exports = async function () {
88
useYarn: true,
99
scenarios: [
1010
{
11-
name: 'ember-lts-3.16',
11+
name: 'ember-lts-3.20',
1212
npm: {
1313
devDependencies: {
14-
'ember-source': '~3.16.0',
14+
'ember-source': '~3.20.7',
1515
},
1616
},
1717
},
1818
{
19-
name: 'ember-lts-3.20',
19+
name: 'ember-lts-3.24',
2020
npm: {
2121
devDependencies: {
22-
'ember-source': '~3.20.5',
22+
'ember-source': '~3.24.3',
2323
},
2424
},
2525
},

tests/integration/components/x-tree-checkbox-test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ module('Integration | Component | x-tree-checkbox', function(hooks) {
1111
this.set('toggleCheck', () => {
1212
this.checked = !this.checked;
1313
});
14+
1415
this.set('model', {});
1516

16-
await render(hbs`<XTreeCheckbox @model={{this.model.model}} @toggleCheck={{action this.toggleCheck}} />`);
17+
await render(hbs`<XTreeCheckbox @model={{this.model}} @toggleCheck={{action this.toggleCheck}} />`);
1718

1819
assert.equal(this.checked, false);
1920

0 commit comments

Comments
 (0)