From da77b79ada880cb657e463b2e7fa1bf9b487bc7a Mon Sep 17 00:00:00 2001 From: adamwang15 Date: Sat, 10 Aug 2024 18:24:40 +1000 Subject: [PATCH] Update cran-comments.md --- cran-comments.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index b319a1b..be437c8 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -27,9 +27,6 @@ It also shows: This is not a problem as `RcppArmadillo` is used in the package and is not a problem to be in `Depends` or `Imports`. We tested various scenarios of includeing `RcppArmadillo` in dependencies, and only the current setup compiles and installs the package correctly. It shows this note nevertheless. - - - ## Checks using `devtools::check_win_devel()` This show as well: @@ -51,10 +48,12 @@ This show as well: All are correct and used intentionally. Thanks! +## Done some more tests from `usethis::use_release_issue()` +All good here! +## Submission notes bsvarSIGNs v1.0.1 +## Checks using `rhub::rhub_check()` -## Done some more tests from `usethis::use_release_issue()` - -All good here! \ No newline at end of file +Passes the Undefined Behavior Sanitizer check as shown [here](https://github.com/bsvars/bsvarSIGNs/actions/runs/10328718577). Thanks!