Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use output buffering in "curl"-lib of your code #8

Open
eerrap opened this issue Jun 25, 2011 · 2 comments
Open

Use output buffering in "curl"-lib of your code #8

eerrap opened this issue Jun 25, 2011 · 2 comments

Comments

@eerrap
Copy link

eerrap commented Jun 25, 2011

Use output buffering in "protected function doCurlCall" in file curl.php to prevent instant output which is not necessary because of return values available!
If this is changed, a developer can decide whether to output the row response from echonest or to process it any further.

@eerrap
Copy link
Author

eerrap commented Jun 25, 2011

May be better not change "curl.php" but change "HttpClient.php" to have the following lines in "request" method:

        ob_start();
        $this->doRequest($url, $parameters, $httpMethod, $options);
        $response = ob_get_contents();
        ob_end_clean();

@bshaffer
Copy link
Owner

bshaffer commented Aug 2, 2011

I've added the raw option on all API objects (see the bottom of the README for more info). Will this accomplish what you're looking for here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants