Curl Resource Request Test #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 8, 2013 09:41
Conflicts: test/ResourceRequestTest.php
Owner
|
Can you please explain to me the reason for this pull request? The "required scope" should be built into the resource action itself, ie hard coded somewhere, and not part of the request, as is the case in this PR. |
Author
|
This pull request is related to bshaffer/oauth2-server-php#254 |
Owner
|
Thank you for this. I am closing this since a test suite for this demo app will require a more standard method of testing (using behat/mink, etc). However, I think the tests you've written would be a great addition to your own app imlementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request is related to bshaffer/oauth2-server-php#254