Skip to content

Commit 34e9ae4

Browse files
committed
runner update
1 parent ce64544 commit 34e9ae4

File tree

12 files changed

+33
-51
lines changed

12 files changed

+33
-51
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
<include>${tests.single}</include>
7979
</includes>
8080
<systemPropertyVariables>
81-
<config>parallel.conf.json</config>
81+
<config>browserstack.conf.json</config>
8282
<local>true</local>
8383
</systemPropertyVariables>
8484
<properties>
@@ -108,7 +108,7 @@
108108
<include>${tests.single}</include>
109109
</includes>
110110
<systemPropertyVariables>
111-
<config>parallel.conf.json</config>
111+
<config>browserstack.conf.json</config>
112112
<local>false</local>
113113
</systemPropertyVariables>
114114
<properties>

src/test/java/runners/BstackRunner.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99

1010
import com.microsoft.playwright.*;
1111
import com.google.gson.JsonObject;
12+
13+
import java.io.UnsupportedEncodingException;
1214
import java.net.URLEncoder;
1315

1416
import org.openqa.selenium.MutableCapabilities;
@@ -112,15 +114,16 @@ public boolean supportsParameter(ParameterContext parameterContext,
112114
@Override
113115
public Object resolveParameter(ParameterContext parameterContext,
114116
ExtensionContext extensionContext) {
115-
try(Playwright playwright = Playwright.create()) {
116-
BrowserType browserType = playwright.chromium();
117-
String caps = URLEncoder.encode(capabilitiesObject.toString(), "utf-8");
118-
System.out.println(capabilitiesObject.toString());
119-
String ws_endpoint = wss + "?caps=" + caps;
120-
browser = browserType.connect(ws_endpoint);
121-
} catch (Exception e) {
122-
e.printStackTrace();
117+
Playwright playwright = Playwright.create();
118+
BrowserType browserType = playwright.chromium();
119+
String caps = null;
120+
try {
121+
caps = URLEncoder.encode(capabilitiesObject.toString(), "utf-8");
122+
} catch (UnsupportedEncodingException e) {
123+
throw new RuntimeException(e);
123124
}
125+
String ws_endpoint = wss + "?caps=" + caps;
126+
browser = browserType.connect(ws_endpoint);
124127
return browser;
125128
}
126129
});

target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/createdFiles.lst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
tests/SingleTest.class
1+
tests/SampleTest.class
22
runners/BstackRunner$1$1.class
33
runners/BstackRunner.class
44
runners/PlaywrightTest.class
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
/Users/rohan/stack/ce_scripts/java-playwright-browserstack/src/test/java/runners/BstackRunner.java
2-
/Users/rohan/stack/ce_scripts/java-playwright-browserstack/src/test/java/tests/SingleTest.java
2+
/Users/rohan/stack/ce_scripts/java-playwright-browserstack/src/test/java/tests/SampleTest.java
33
/Users/rohan/stack/ce_scripts/java-playwright-browserstack/src/test/java/runners/PlaywrightTest.java
44
/Users/rohan/stack/ce_scripts/java-playwright-browserstack/src/test/java/utils/SetupLocalTesting.java

target/surefire-reports/TEST-tests.SingleTest.xml renamed to target/surefire-reports/TEST-tests.SampleTest.xml

Lines changed: 10 additions & 21 deletions
Large diffs are not rendered by default.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
-------------------------------------------------------------------------------
2+
Test set: tests.SampleTest
3+
-------------------------------------------------------------------------------
4+
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.088 s - in tests.SampleTest

target/surefire-reports/tests.SingleTest.txt

Lines changed: 0 additions & 16 deletions
This file was deleted.

target/test-classes/conf/parallel.conf.json renamed to target/test-classes/conf/browserstack.conf.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,15 @@
2626
"os": "OS X",
2727
"os_version": "Monterey",
2828
"name": "Test on Safari",
29-
"browser": "playwright-webkit"
29+
"browser": "playwright-webkit",
30+
"browser_version": "latest"
3031
},
3132
{
3233
"os": "OS X",
3334
"os_version": "Ventura",
3435
"name": "Test on Bundled Firefox",
35-
"browser": "playwright-firefox"
36+
"browser": "playwright-firefox",
37+
"browser_version": "latest"
3638
}
3739
]
3840
}
-76 Bytes
Binary file not shown.
0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)