Skip to content

Commit c4f18be

Browse files
committed
Merge pull request #132 from shirish87/retry_fix
Retry URL Fixes. Earlier commits missed setting the flag correctly. Closes #131.
2 parents b8d44c0 + aadc5a0 commit c4f18be

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

bin/cli.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,8 @@ function attachWorkerHelpers(worker) {
206206
// TODO: Consider creating instances of a proper 'Worker' class
207207

208208
worker.buildUrl = function buildUrl(test_path) {
209-
return buildTestUrl(test_path || this.test_path, this._worker_key, this.getTestBrowserInfo());
209+
var workerKey = workerKeys[this.id] ? workerKeys[this.id].key : null;
210+
return buildTestUrl(test_path || this.test_path, workerKey, this.getTestBrowserInfo());
210211
};
211212

212213
worker.getTestBrowserInfo = function getTestBrowserInfo(test_path) {
@@ -287,7 +288,7 @@ var statusPoller = {
287288
worker.awaitAck();
288289

289290
worker.activityTimeout = setTimeout(function () {
290-
if (!worker.acknowledged) {
291+
if (!worker.isAckd) {
291292
var subject = 'Worker inactive for too long: ' + worker.string;
292293
var content = 'Worker details:\n' + JSON.stringify(worker.config, null, 4);
293294
utils.alertBrowserStack(subject, content, null, function(){});
@@ -308,7 +309,7 @@ var statusPoller = {
308309
}, activityTimeout * 1000);
309310

310311
worker.testActivityTimeout = setTimeout(function () {
311-
if (worker.acknowledged) {
312+
if (worker.isAckd) {
312313
var subject = 'Tests timed out on: ' + worker.string;
313314
var content = 'Worker details:\n' + JSON.stringify(worker.config, null, 4);
314315
utils.alertBrowserStack(subject, content, null, function(){});

0 commit comments

Comments
 (0)