Skip to content

Irrelevant warnings because devDependencies are listed in dependencies #77

Closed
@devoto13

Description

@devoto13

Expected Behavior

npm install browserstack-local does not produce any warnings, when I install it.

Actual Behavior

$ npm install browserstack-local
npm WARN deprecated [email protected]: This package is unmaintained. Use @sinonjs/formatio instead
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam

Steps to Reproduce the Problem

  1. npm install browserstack-local

browserstack local arguments

Not relevant.

Platform details

  1. browserstack-local-nodejs version: latest
  2. node version: any
  3. os type and version: any

Details

Warnings come from the sinon dependency, which is only used in tests, but for some reason listed as a production dependency. There were several PRs (#54, #70, #71) attempting to fix this issue, which all were silently ignored. What is the problem? What needs to be done to get one of them reviewed and merged?

In particular #54 does not do any extra changes, which may be risky, but plainly removes unnecessary dependencies, so consumers don't have to install them and see irrelevant warning.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions