Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caniuse-lite includes features not shown on caniuse.com #119

Closed
ddbeck opened this issue Aug 24, 2023 · 4 comments · Fixed by #120
Closed

caniuse-lite includes features not shown on caniuse.com #119

ddbeck opened this issue Aug 24, 2023 · 4 comments · Fixed by #120

Comments

@ddbeck
Copy link
Contributor

ddbeck commented Aug 24, 2023

Some of the features in https://github.com/Fyrd/caniuse/tree/main/features-json aren't actually shown on caniuse, such as css-grid-animation (they have shown: false set). However, caniuse-lite includes these features.

Would you consider omitting those features, or including the shown key from caniuse? I'd prefer to be able to use only those features that I can link to on caniuse.com.

What I expected
"css-grid-animation" in lite.featuresfalse
Alternatively: lite.feature(lite.features["css-grid-animation"]).shownfalse

What I get:
"css-grid-animation" in lite.featurestrue
lite.feature(lite.features["css-grid-animation"]).shownundefined

@ai
Copy link
Member

ai commented Aug 24, 2023

  1. What benefits will we have by omitting them?
  2. Are we sure that Autoprefixer and other caniuse-lite users don’t use them?

@dfabulich
Copy link

Seems like including the shown key is the best fix here.

@ddbeck
Copy link
Contributor Author

ddbeck commented Aug 25, 2023

I didn't consider other consumers of this—I don't know who else is using this or why. 🤷 I can see now that it would be a bad choice to omit those features and agree that a better option is to include the shown key.

(Though I'm skeptical that features not shown on caniuse are as well-maintained and accurate as the ones that are—there's going to be a lot fewer eyes on those features.)

@ai
Copy link
Member

ai commented Aug 25, 2023

agree that a better option is to include the shown key.

Does somebody really need a filter to show only features shown on Can I Use. If yes, we can add this key (send PR).

Though I'm skeptical that features not shown on caniuse are as well-maintained and accurate as the ones that are

It is better than nothing (for the case of Autoprefixer, for instance)

ddbeck added a commit to ddbeck/caniuse-lite that referenced this issue Aug 25, 2023
ddbeck added a commit to ddbeck/caniuse-lite that referenced this issue Aug 25, 2023
@ddbeck ddbeck mentioned this issue Aug 25, 2023
@ai ai closed this as completed in #120 Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants