Skip to content

Commit 618e987

Browse files
fix(tests): fix: tests which call HTTP endpoints directly with the example parameters
1 parent 6357f33 commit 618e987

File tree

1 file changed

+12
-33
lines changed

1 file changed

+12
-33
lines changed

tests/test_client.py

Lines changed: 12 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@
2323

2424
from browserbase import Browserbase, AsyncBrowserbase, APIResponseValidationError
2525
from browserbase._types import Omit
26-
from browserbase._utils import maybe_transform
2726
from browserbase._models import BaseModel, FinalRequestOptions
28-
from browserbase._constants import RAW_RESPONSE_HEADER
2927
from browserbase._exceptions import APIStatusError, APITimeoutError, BrowserbaseError, APIResponseValidationError
3028
from browserbase._base_client import (
3129
DEFAULT_TIMEOUT,
@@ -35,7 +33,6 @@
3533
DefaultAsyncHttpxClient,
3634
make_request_options,
3735
)
38-
from browserbase.types.session_create_params import SessionCreateParams
3936

4037
from .utils import update_env
4138

@@ -725,32 +722,21 @@ def test_parse_retry_after_header(self, remaining_retries: int, retry_after: str
725722

726723
@mock.patch("browserbase._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
727724
@pytest.mark.respx(base_url=base_url)
728-
def test_retrying_timeout_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
725+
def test_retrying_timeout_errors_doesnt_leak(self, respx_mock: MockRouter, client: Browserbase) -> None:
729726
respx_mock.post("/v1/sessions").mock(side_effect=httpx.TimeoutException("Test timeout error"))
730727

731728
with pytest.raises(APITimeoutError):
732-
self.client.post(
733-
"/v1/sessions",
734-
body=cast(object, maybe_transform(dict(project_id="your_project_id"), SessionCreateParams)),
735-
cast_to=httpx.Response,
736-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
737-
)
729+
client.sessions.with_streaming_response.create(project_id="projectId").__enter__()
738730

739731
assert _get_open_connections(self.client) == 0
740732

741733
@mock.patch("browserbase._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
742734
@pytest.mark.respx(base_url=base_url)
743-
def test_retrying_status_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
735+
def test_retrying_status_errors_doesnt_leak(self, respx_mock: MockRouter, client: Browserbase) -> None:
744736
respx_mock.post("/v1/sessions").mock(return_value=httpx.Response(500))
745737

746738
with pytest.raises(APIStatusError):
747-
self.client.post(
748-
"/v1/sessions",
749-
body=cast(object, maybe_transform(dict(project_id="your_project_id"), SessionCreateParams)),
750-
cast_to=httpx.Response,
751-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
752-
)
753-
739+
client.sessions.with_streaming_response.create(project_id="projectId").__enter__()
754740
assert _get_open_connections(self.client) == 0
755741

756742
@pytest.mark.parametrize("failures_before_success", [0, 2, 4])
@@ -1554,32 +1540,25 @@ async def test_parse_retry_after_header(self, remaining_retries: int, retry_afte
15541540

15551541
@mock.patch("browserbase._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
15561542
@pytest.mark.respx(base_url=base_url)
1557-
async def test_retrying_timeout_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
1543+
async def test_retrying_timeout_errors_doesnt_leak(
1544+
self, respx_mock: MockRouter, async_client: AsyncBrowserbase
1545+
) -> None:
15581546
respx_mock.post("/v1/sessions").mock(side_effect=httpx.TimeoutException("Test timeout error"))
15591547

15601548
with pytest.raises(APITimeoutError):
1561-
await self.client.post(
1562-
"/v1/sessions",
1563-
body=cast(object, maybe_transform(dict(project_id="your_project_id"), SessionCreateParams)),
1564-
cast_to=httpx.Response,
1565-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
1566-
)
1549+
await async_client.sessions.with_streaming_response.create(project_id="projectId").__aenter__()
15671550

15681551
assert _get_open_connections(self.client) == 0
15691552

15701553
@mock.patch("browserbase._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
15711554
@pytest.mark.respx(base_url=base_url)
1572-
async def test_retrying_status_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
1555+
async def test_retrying_status_errors_doesnt_leak(
1556+
self, respx_mock: MockRouter, async_client: AsyncBrowserbase
1557+
) -> None:
15731558
respx_mock.post("/v1/sessions").mock(return_value=httpx.Response(500))
15741559

15751560
with pytest.raises(APIStatusError):
1576-
await self.client.post(
1577-
"/v1/sessions",
1578-
body=cast(object, maybe_transform(dict(project_id="your_project_id"), SessionCreateParams)),
1579-
cast_to=httpx.Response,
1580-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
1581-
)
1582-
1561+
await async_client.sessions.with_streaming_response.create(project_id="projectId").__aenter__()
15831562
assert _get_open_connections(self.client) == 0
15841563

15851564
@pytest.mark.parametrize("failures_before_success", [0, 2, 4])

0 commit comments

Comments
 (0)