error rendering internal error

[shriram]

This may be the same problem as #1471, but this is a smaller program.

Running

include plot

t = table:  label, value
  row: "x", "25"
  row: "y", "100"
  row: "z", "1000"
end

pie-chart(t, _.{title: "Chart"})

produces

[shriram]

Note that I intentionally have strings instead of numbers in the value column, which is illegal per the documentation. So perhaps there should (also) have been an annotation check somewhere else. It's not wrong that this program produces an error; it should. It just shouldn't run into an internal error.

[sorawee]

So perhaps there should (also) have been an annotation check somewhere else.

This is fixed in the chart library, FWIW.

include chart

a-series = from-list.exploding-pie-chart(
  [list: "Pyret", "OCaml", "C", "C++", "Python", "Racket", "Smalltalk"],
  [list: "10",       6,       1,   3,     5,       8,        9],
  [list: 0.2,      0,       0,   0,     0,       0.1,      0])
render-chart(a-series).display()

produces:

The annotation, Number, at builtin://chart:45:19-45:25

was not satisfied by the value

"10"

[sorawee]

I'm actually not sure if there's anything @jswrenn could do to improve this (though I might be wrong). It is really an internal error, and there's not really any srcloc to report on.

[blerner]

This is definitely busted, and it's unclear whether the problem is in error rendering, or in the plot library, or both. The objectionable code is

    var sum = tab.map(function (row) { return row[1]; })
      .reduce(function (a, b) {
        return jsnums.add(a, b, RUNTIME.NumberErrbacks);
      });

where one of a or b isn't a number, and so jsnums.add tries to call a.add which doesn't exist, and causes a JS error. That could be a bug in the js-numbers library, which is failing to throw a domain error when given non-js-number values. That JS error then causes reduce to die, so the plot library is failing to sanitize its inputs also. Finally, I'm not convinced that even if you had a list of numbers, if they triggered a NumberErrbacks exception (e.g. via numeric overflow or whatnot), whether that errback would flow out to the error rendering code properly. So there is a lot to fix, here.