Can we please not put typescript definitions to the final package

[RachelSatoyama]

By default typescript tries to resolve declaration by searching, among other locations, in node_modules project - that leads to duplicate definition error which is not that trivial to get rid off (at least some not that well documented steps should be taken).

Here's a link to give you an idea - microsoft/TypeScript#6964

It would be very nice if typescript definitions won't be included to the final package.
After all not a big deal but those a just redundant files that a increasing package size for no reason.

[ssougnez]

Hi,

especially when "@types/base64url" exists (for TS 2).

I ended up not using this package because of all the duplicates error I got.

Regards

[jor-rit]

Yes, this can cause duplicate definitions because of the included node typings.

Would be even better to just drop typings, since it's not needed anymore with TypeScript 2.0

I see somebody already did it, but there's no pull request for it yet...?
https://github.com/microshine/base64url

[philkunz]

This package is coded in TypeScript and typings are already linked in package.json. So just remove the typings directory and define @types/node as peer dependency. No need for any other external @types scoped modules.

[heycalmdown]

I made npm://base64url-adhoc for temporary use before #18 accepted. You can't replace this with the original library inside existing module like jsonwebtoken. Just use it for typing if you use base64url directly in your code.

[andybarron]

I'm getting bitten by this too -- the duplicate definitions error :/

[kumar-muthu]

I ended up writing an ugly build script using gulp, to delete all .ts files from the nodemodules\base64url folder before compiling my typescript project. This works for me.

[philkunz]

I was subscribed to this subject for some reason.
Just use js-base64, it is a way better lib.

[rageycomma]

@philkunz So far as I can see, js-base64 does not include base64url support, so therefore, your suggestion is not that helpful, considering that's what this package is. The alternative is base64-url which does do base64url encoding, however, I like this package, shame about the TS bindings making my life a pain. :P

[philkunz]

@rageycomma Then you can't see very far.

[michaeloscarli]

This issue has been resolved in v3.0.0

[MylesBorins]

Closing as resolved