Skip to content

Commit 661b369

Browse files
committed
chore: attempt fix tests
1 parent e50936c commit 661b369

File tree

1 file changed

+10
-16
lines changed

1 file changed

+10
-16
lines changed

packages/pg/test/integration/connection-pool/result-size-limit-tests.js

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,33 +6,27 @@ var assert = require('assert')
66

77
const suite = new helper.Suite()
88

9-
// Test that the pool respects the maxResultSize option
10-
suite.test('pool respects maxResultSize option', (done) => {
9+
suite.testAsync('large result triggers error', async () => {
1110
const pool = new pg.Pool({
1211
...helper.args,
1312
maxResultSize: 1024, // very small limit
1413
})
1514

16-
pool.on('error', (err) => {
17-
if (err.code === 'RESULT_SIZE_EXCEEDED') {
18-
return done()
19-
}
20-
})
21-
2215
const largeQuery = `
2316
SELECT generate_series(1, 1000) as num,
2417
repeat('x', 100) as data
2518
`
2619

27-
pool.query(largeQuery, (err) => {
28-
if (!err) {
29-
return done(new Error('Expected query to fail with size limit error'))
30-
}
31-
32-
if (err.code !== 'RESULT_SIZE_EXCEEDED') {
33-
return done(new Error(`Expected RESULT_SIZE_EXCEEDED error but got: ${err.message} (${err.code})`))
34-
}
20+
pool.on('error', (err) => {
21+
assert.equal(err.code, 'RESULT_SIZE_EXCEEDED')
3522
})
23+
24+
try {
25+
await pool.query(largeQuery)
26+
throw new Error('should have raised RESULT_SIZE_EXCEEDED error')
27+
} catch (err) {
28+
assert.equal(err.code, 'RESULT_SIZE_EXCEEDED')
29+
}
3630
})
3731

3832
suite.test('pool query works with adequate maxResultSize', (done) => {

0 commit comments

Comments
 (0)