Skip to content

Commit 8c39bce

Browse files
committed
fix bug introduced in v0.2.8
thanks very much to Steve for reporting and providing test-case.
1 parent 70d6264 commit 8c39bce

File tree

4 files changed

+29
-1
lines changed

4 files changed

+29
-1
lines changed

src/slivarpkg/gnotate.nim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ proc parseLong(line: string, n_fields:int): Long {.inline.} =
101101

102102

103103
proc readLongs(g:var Gnotater, chrom: string) =
104+
g.longs.setLen(0)
104105

105106
var big = newString(16)
106107
doAssert g.zip.read_into(&"sli.var/{chrom}/long-alleles.txt", big)

src/slivarpkg/version.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
const slivarVersion* = "0.2.8"
1+
const slivarVersion* = "0.2.9"
22
const slivarGitCommit* = staticExec("git rev-parse --verify HEAD")

tests/functional-tests.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ assert_equal "0" "$(bcftools view -H -i 'FMT/DP[0] <= 10 || FMT/DP[1] <= 10 || F
5454
assert_equal 11 $(bcftools view -H xx.bcf | wc -l)
5555

5656

57+
5758
run check_denovo_with_filter $exe expr --js js/slivar-functions.js -v tests/ashk-trio.vcf.gz --pass-only --trio "denovo:variant.FILTER == 'PASS' && kid.alts == 1 && mom.alts == 0 && dad.alts == 0 && (mom.AD[1] + dad.AD[1]) < 2 && kid.GQ > 10 && mom.GQ > 10 && dad.GQ > 10 && kid.DP > 10 && mom.DP > 10 && dad.DP > 10" --ped tests/ashk-trio.ped -o xx.bcf
5859

5960
assert_exit_code 0
@@ -217,3 +218,10 @@ assert_in_stderr "[slivar] warning! BCSQ has a CSQ of @63280473 which is incompl
217218
[slivar] warning! BCSQ has a CSQ of @788407 which is incomplete. skipping chr16:793183(G/A)
218219
[slivar] warning! BCSQ has a CSQ of @3592545 which is incomplete. skipping chr19:3593228(G/A)"
219220
rm x.vcf.gz
221+
222+
223+
run check_indel_bug_setup $exe make-gnotate -f AF:gno_af tests/indel-bug.vcf --prefix tests/indel-bug
224+
run check_indel_bug $exe expr -g tests/indel-bug.zip -v tests/indel-bug.vcf -o x.vcf
225+
assert_equal 0 $(bcftools query -f "%AF\t%gno_af" x.vcf | awk '$1 != $2' | wc -l)
226+
rm x.vcf
227+

tests/indel-bug.vcf

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
##fileformat=VCFv4.2
2+
##FILTER=<ID=PASS,Description="All filters passed">
3+
##INFO=<ID=AF,Number=1,Type=Float,Description="field from from gnotate VCF">
4+
#CHROM POS ID REF ALT QUAL FILTER INFO
5+
chr3 57446013 . ATAAATAAATAAT A 230919 PASS AF=0.574454
6+
chr4 443460 . CCACATGTGTAGGGTTTCTCTCCAGTATGAATTCTCCTATGTACATAAAGGTTTGCGGACTGTCTAAAGGCTTTGCCACATACTT C 274.8 PASS AF=0
7+
chr5 80300545 . G GTCCCTCTCCCTC 114541 PASS AF=0.386214
8+
chr6 31028873 . A ACCTCTACTGAAGGCTCTGAGACCACCACAG 13662.3 PASS AF=0.1145
9+
chr6 31028943 . C CAGGCTCTGAGACCACCACAGCCTCTACTGA 7768.74 PASS AF=0.048706
10+
chr9 32986034 . AAAAAAAAACAAAAAAAAAAAC A 118886 PASS AF=0.476683
11+
chr9 35183034 . CGCTCCTCACTTCCCAGATGGGGCGGCCGGGCAGAGGCGCTCCTCACCTCCCAGACGGGGCGGCCTGGCAGAGGT C 56269 PASS AF=0.229961
12+
chr10 2501862 . ACCCGGCTCACCTCAACAACAAAGCGCGGTTTCCTCCCTCGCCATCCTTCCTCG A 99790.2 PASS AF=0.186495
13+
chr10 42429112 . TCACCTTTGCTTGATATGATAATATAGTGCCAAGG T 120274 PASS AF=0.482119
14+
chr11 10353386 . TTTTTCTTTTTCTTTTCTTTTCTTTTCTTTTCTTTTCTTTTCTTTTCTTTTCTTTTCTTTTC T 11465.2 PASS AF=0.652204
15+
chr16 3197578 . TGGCCACATGTCAAGGGCTCCAGAGCCACCTGCTGCTGGGGGCCAGTTCCTCAGACAGCGCAGTCCTACATCTGACTACAAGCTTAAATG T 212370 PASS AF=0.67148
16+
chr17 40819040 . AGCCGCCGCCGGAACTGCCGCCGTGGCCGCCGCCGTG A 651.56 PASS AF=0.00191424
17+
chr17 40819055 . TGCCGCCGTGGCC T 78807.4 PASS AF=0.329802
18+
chr19 58404775 . GGGCAGAGGGGCTCCTCATTTCCCAGTAGGGGCGGCCGGGCAGAGGCGCCCCTCACCTCCCGGACAGGGCGGCTCGCCAGGCGGGGGGCTGACCCCCCCCCCCACCTCCCTCCTGGACGGGGCGGCTGGCCA G 1168.4 PASS AF=0.0145961
19+
chr20 37179387 . G GCTTACAGACAGGGCCCCGCGGCCGGCACT 700721 PASS AF=0.504156

0 commit comments

Comments
 (0)