-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Procedural filter causing full page block in Brave #43818
Comments
cc: @ryanbr |
I documented all these issues in #42873 and Brave team has not fixed it. You can see in the comment #42873 (comment) how I mentioned exactly this, and how You can read it in their wiki, the last paragraph https://github.com/gorhill/ublock/wiki/Procedural-cosmetic-filters#subjectmatches-patharg
So, you need to create an exception I will mention this anyway, I think it is ridiculous to use Procedurals, just to use them, not even uBlock recommends the use of them, why? because they are not native selectors, they are made of JS, that means you could easily create Custom Scriptlets that work better than the current Procedurals and do the job, but it will always be slower than native CSS selectors that only modify CSS properties. As uBlock says in their wiki :
and this one to explain what I already said:
Anyway, the issue is Brave hasn't fixed their Procedural Filtering knowing it is currently buggy... so it's better to avoid it at all cost, even more than in uBlock where it works fine (but slow). I reported it 2 months ago, with no fix yet, so even if you change the PS. This list is also available in Brave, it's the regional list in brave://settings/shields/filters called PSS. Also, Cosmetics don't "Block" they hide... all cosmetics do (Native or Procedural) is to inject the CSS declaration |
@ghost |
Description
I am experiencing an issue with a procedural filter from the Adguard Annoyances filter list when using the Brave browser with the built-in adblock-rust. The filter in question is:
ya.ru,yandex.*##:matches-path(/images).ImagesViewer-Products
Filter list URL: https://filters.adtidy.org/extension/ublock/filters/14.txt
This filter is offered in uBlock Origin, although not enabled by default. It works correctly in uBlock Origin on both Chrome and Firefox, but in Brave, it results in the entire page being blocked, displaying only a white screen.
NOTE: There are similar procedural filters in the filter list like
ya.ru,yandex.*##:matches-path(/SOMETHING_ELSE)..., causing a white screen issue on other pages, such as yandex.com/SOMETHING_ELSE
Steps to reproduce
Actual result
The entire page is blocked, displaying only a white screen.
Expected result
The filter should block only the specified elements without causing the entire page to be blocked.
Reproduces how often
Easily reproduced
Desktop Brave version (brave://version info)
1.75.175 Chromium: 133.0.6943.54
Windows 11 Version 24H2 (Build 26100.2894)
Android device
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: