Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not blocking some ads #413

Open
KillerKingSolo opened this issue Jan 2, 2025 · 2 comments
Open

Not blocking some ads #413

KillerKingSolo opened this issue Jan 2, 2025 · 2 comments

Comments

@KillerKingSolo
Copy link

All adblock rules are set to aggressive and every ruleset/list is checked. But still some ads are getting though.

https://superadblocktest.com/
image

https://d3ward.github.io/toolz/adblock
image

@nicklvh
Copy link

nicklvh commented Jan 5, 2025

It's not the package, this is most likely just outdated URLs that these tests are using, or the filter lists are letting some slip.

This is more of an issue with this ad block test. if you see an ad slip on an actual website (which adblocking is meant for) then you can report that to the easy list filter list

@TEMP-ad
Copy link

TEMP-ad commented Jan 10, 2025

Do you understand these "are not ads" but terrible tests that don't really measure anything?

This is exactly why Gorhill wrote on twitter long time ago in https://x.com/gorhill/status/1583581072197312512

Please do not use those online tools which claim to measure how good is your content blocker, they are often flawed.

and especially this one:

Filter list maintainers are already quite burdened with dealing with real, actual filter issues, they shouldn't have to spend on made up issues by such dubious online tools.

This is also the adblock-rust repository, not even the lists one... which is obvious not even meant for this issue. If you don't know what features Brave adblocker supports or not, well, research, make tests, compare it to ABP, Adguard and uBlock documentation. If it not about a feature that uBlock has to block X or Y ad or tracker... then how can this issue be in any shape or form valid?

It's clear you don't understand how adblockers work. But Adblockers are about features and rules, if a rule is not supported it is a useless rule, if a feature exist and a rule doesn't exist, you report and filter maintainers will make sure to use whatever feature is available to block X or Y.
The uBlock parity Brave is trying to reach is not even a limitation, because even if Brave doesn't support some features uBlock uses in their lists, you can still make use of other features to do the same job.

But In the case of Brave, it is close to what uBlock offers in features, so it's mostly about few workarounds and uBlock lists being read 96.42%, but of course the point is to reach 99.9% parity and don't need too many workarounds or none at all.

But talking about these tests, the reality of the web is not black and white like these terrible tests try to make it seem. This is why adblockers like Brave, uBlock, Adguard and ABP will offer Scriptlet Injections, Cosmetics, Procedural Cosmetics, Redirections, Network Request filtering and even with all those features, there are many settings and option to choose from.... and sometimes even with all the advanced features, especially Scriptlet Injections (which is injecting JavaScript to do whatever in a page) trackers and ads need to be whitelisted, or ignored, and until new scriptlets or features can be implemented to deal with those.

That's why things like redirections exist now inside Adblockers, and that's something these useless tests don't tell you. These tests try to make it seem like applying some Cosmetics and Some network request filters are enough... but no, the most advanced form of adblocking, which is Scriptlets is what it is needed to deal with ads like Youtube for example, so obviously you can block a lot of thing at a network level, but that will never be enough, because sometimes you need to get in the web pages code and modify it to deal with many types of annoyances or ads or anti adblockers.

So please, stop using these tests and making issues that don't belong to adblock-rust, if you have anything to say, it would be better if you go to community brave, and ask questions there and report REAL issues from websites there by using the adblocking category.
These percentages mean nothing, and people reporting issues and saying how effective an adblocker is based on that is really bad.

in fact, in most of these tests you can use the most terrible type of adblocker, DNS, and get 100%... that's how bad it is.

Also, you don't take into account how adblocker need rules to do the job, they are not magical beings that are blocking automatically things, all their job is based on the hard and free work of many filter maintainers to make an adblocker work... so yeah, you make rules to reduce tracking and ads as much as possible, but the features can exist and they will do nothing if there are not rules telling them what to do.

This is why you can find in uBlock lists (which Brave uses) specific rules to deal with these terrible tests, but in some cases Easylist nor uBlock want to add fake rules and fill the lists with fake rules just to make these tests 100%.

You can read the old Tweet from gorhill and understand why the issue of using these terrible tests, but it is exactly this type of issues the reason why he made that tweet, because people go around and make issues or questions "why is uBlock not blocking 100%" and I guess he got tired of answering the same thing because people don't research how adblockers work, and they pretend these tests can really give an idea how adblockers work in real scenarios, and no, they will not do it, because they are far from reality.

Hope you understand that these tests are garbage and nothing needs to be blocked from fake tests, and hope you research how adblockers work to make your own rules if Brave is not blocking something uBlock does, or something nobody does and use Adblockers for anything, because adblockers have the power to go beyond blocking or modifying trackers or ads, but whole pages and add features and replace extensions (like sponsorblock or returndislikebutton, FFZ or BTTV, useful for mobile since it doesn't support extensions) and it can be use for anything, Brave can do it, uBlock has more features but Brave will try to reach more uBo Parity this year for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants