Skip to content
This repository was archived by the owner on Feb 1, 2024. It is now read-only.

Commit 54c90cb

Browse files
committed
Fix retries & write_csv
1 parent 446bad7 commit 54c90cb

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

components/result_map.py

+2
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,5 @@ def write_csv(self, output_file: str, append: bool):
6161
rstdev = stdev / avg if avg > 0 else 0
6262
result_writer.writerow([metric_str, browser, version] +
6363
[avg, stdev, rstdev] + [''] + values)
64+
self._map = {}
65+
self._error = {}

measure.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,22 @@ def main():
6666
browser_name = browser_class().name()
6767
browser_version = browser_class().get_version()
6868
logging.info('Testing %s %s', browser_name, browser_version)
69-
attempt = 0
70-
71-
for iteration in range(repeat):
69+
failed_iteration_count = 0
70+
good_iteration_count = 0
71+
while good_iteration_count < repeat:
7272
try:
73-
metrics = measure.Run(iteration, browser_class)
73+
metrics = measure.Run(good_iteration_count, browser_class)
7474
logging.debug([test_name, browser_name, browser_version, metrics])
7575
for metric, key, value in metrics:
7676
results.addValue(browser_name, browser_version, metric, key, value)
77+
good_iteration_count += 1
7778
except Exception as e:
78-
attempt += 1
79-
if attempt <= args.retry_count:
79+
failed_iteration_count += 1
80+
if failed_iteration_count <= args.retry_count:
8081
logging.error('Got error %s, retrying', e)
81-
iteration -= 1
8282
else:
8383
final_messages.append(
84-
f'{test_name}/{browser_name}/{iteration} failed')
84+
f'{test_name}/{browser_name}/{good_iteration_count} failed')
8585
raise
8686

8787
results.write_csv(args.output, args.append)

0 commit comments

Comments
 (0)