Merge pull request #93 from brainstormforce/hidden-comments

Breaking: Show comments for a unlisted posts

Author: Nikschavan

Diff for: class-unlist-posts.php

@@ -64,7 +64,6 @@ public function init() {
 			add_action( 'wp_head', array( $this, 'hide_post_from_searchengines' ) );
 			add_filter( 'wp_robots', array( $this, 'no_robots_for_unlisted_posts' ) );
 			add_filter( 'rank_math/frontend/robots', array( $this, 'change_robots_for_rankmath' ) );
-			add_filter( 'comments_clauses', array( $this, 'comments_clauses' ), 20, 2 );
 			add_filter( 'wp_list_pages_excludes', array( $this, 'wp_list_pages_excludes' ) );
 		}
 
@@ -205,37 +204,6 @@ public function no_robots_for_unlisted_posts( $robots ) {
 			return $robots;
 		}
 
-		/**
-		 * Filter where clause to hide selected posts.
-		 *
-		 * @since  1.0.1
-		 *
-		 * @param  Array    $clauses Comment Query Clauses.
-		 * @param  WP_Query $query WP_Query &$this The WP_Query instance (passed by reference).
-		 *
-		 * @return String $where Where clause.
-		 */
-		public function comments_clauses( $clauses, $query ) {
-
-			// Bail if posts unlists is disabled.
-			if ( false === $this->allow_post_unlist() ) {
-				return $clauses;
-			}
-
-			$hidden_posts = get_option( 'unlist_posts', array() );
-
-			// bail if none of the posts are hidden or we are on admin page or singular page.
-			if ( ( is_admin() && ! wp_doing_ajax() ) || empty( $hidden_posts ) ) {
-				return $clauses;
-			}
-
-			$where            = $clauses['where'];
-			$where           .= ' AND comment_post_ID NOT IN ( ' . esc_sql( $this->hidden_post_string() ) . ' ) ';
-			$clauses['where'] = $where;
-
-			return $clauses;
-		}
-
 		/**
 		 * Exclude the unlisted posts from the wp_list_posts()
 		 *

Diff for: tests/test-comments-unlisted-post.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * Class CommentsUnlistedPost
+ *
+ * @package Unlist_Posts
+ */
+
+/**
+ * Make sure unlisted posts are hidden from get_adjacent_post().
+ */
+class CommentsUnlistedPost extends WP_UnitTestCase {
+	/**
+	 * Test that posts of an unlisted comment are shown.
+	 */
+	public function test_comments_unlisted_post() {
+		$editor_user_id = self::factory()->user->create(
+			array(
+				'role' => 'editor',
+			)
+		);
+
+		wp_set_current_user( $editor_user_id );
+
+		// Create an listed post.
+		$listed_post = self::factory()->post->create();
+
+		// Add comments for the post.
+		$comment_ids = array();
+		for ( $i = 0; $i < 5; $i++ ) {
+			$comment_ids[] = self::factory()->comment->create(
+				array(
+					'comment_post_ID' => $listed_post,
+				)
+			);
+		}
+
+		// Set the post as unlisted.
+		$_POST['unlist_posts']       = true;
+		$_POST['unlist_post_nounce'] = wp_create_nonce( 'unlist_post_nounce' );
+		Unlist_Posts_Admin::instance()->save_meta( $listed_post );
+
+		// Get comments for the post.
+		$comments = get_comments(
+			array(
+				'post_id' => $listed_post,
+			)
+		);
+
+		$this->assertCount( 5, $comments );
+	}
+}