chore: add no-namespace linter rule to project (#60)

* refactor(eslint): apply eslint import/recommended rules

* refactor: add no-namespace linter

importing with wildcard hurts build time since more files should be analyzed by build tool

* refactor(generators): update type imports

Author: kopach

.eslintrc.json

@@ -8,8 +8,10 @@
   },
   "overrides": [
     {
-      "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
+      "files": ["*.[jt]s?(x)"],
+      "extends": ["eslint:recommended", "plugin:import/recommended"],
       "rules": {
+        "import/no-unresolved": "off",
         "@nx/enforce-module-boundaries": [
           "error",
           {
@@ -25,6 +27,13 @@
         ]
       }
     },
+    {
+      "files": ["*.[jt]s?(x)"],
+      "excludedFiles": ["*.spec.ts", "*.spec.tsx"],
+      "rules": {
+        "import/no-namespace": "error"
+      }
+    },
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["plugin:@nx/typescript"],

docs/docs-site/components/ui/button.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import { Slot } from '@radix-ui/react-slot';
 import { cva, type VariantProps } from 'class-variance-authority';
 

docs/docs-site/components/ui/card.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 import { cn } from '@/lib/utils';
 

libs/e2e-testing-providers/src/lib/ioc/contextContainer.ts

@@ -2,9 +2,8 @@ import {Container} from 'inversify';
 import {
   AppContextType,
   APP_CONTEXT_IDENTIFIER,
-} from '@brainly-gene/core';
+ActionType, makeStore} from '@brainly-gene/core';
 
-import {ActionType, makeStore} from '@brainly-gene/core';
 
 
 

libs/e2e-testing-providers/src/lib/ioc/serviceClientsContainer.ts

@@ -1,8 +1,11 @@
 import { Container } from 'inversify';
-import { factory, Factory } from '@brainly-gene/core';
-import { ServiceTypes } from '@brainly-gene/core';
+import { factory, Factory, ServiceTypes } from '@brainly-gene/core';
 import { QueryClient } from '@tanstack/react-query';
-import { ApolloClient, InMemoryCache, NormalizedCacheObject } from '@apollo/client';
+import {
+  ApolloClient,
+  InMemoryCache,
+  type NormalizedCacheObject,
+} from '@apollo/client';
 
 export function useServiceClientsContainer() {
   const apolloClient = new ApolloClient({

libs/e2e-testing-providers/src/lib/storybook/decorators/StorybookProviders.tsx

@@ -1,9 +1,17 @@
-import * as React from 'react';
-import { Provider } from '@brainly-gene/core';
+import React from 'react';
+import {
+  Provider,
+  Router,
+  useMockedRouterContainer,
+  getAssetsContainer,
+  NATIVE_IMAGE,
+  emit,
+  EventBusContextProvider,
+  register,
+} from '@brainly-gene/core';
 
 import styles from './StorybookProviders.module.scss';
-import { Container, interfaces } from 'inversify';
-import { Router, useMockedRouterContainer } from '@brainly-gene/core';
+import { Container, type interfaces } from 'inversify';
 
 import {
   AppStoreType,
@@ -12,8 +20,6 @@ import {
   useServiceClientsContainer,
 } from '../../ioc';
 import { Locale, LinkRewriteContextProvider } from '@brainly-gene/next';
-import { getAssetsContainer, NATIVE_IMAGE } from '@brainly-gene/core';
-import { emit, EventBusContextProvider, register } from '@brainly-gene/core';
 
 type OverwritableContainerKeys = 'adsContainer';
 

packages/gene-apollo/src/apollo/apolloFactory.ts

@@ -1,5 +1,5 @@
 import merge from 'deepmerge';
-import { ApolloClient, NormalizedCacheObject } from '@apollo/client';
+import { ApolloClient, type NormalizedCacheObject } from '@apollo/client';
 export interface ApolloClientType {
   hydrate: (initialState?: NormalizedCacheObject) => void;
   dehydrate: () => unknown;

packages/gene-apollo/src/apollo/makeWatchQuery.ts

@@ -1,16 +1,16 @@
 import {
   ApolloClient,
-  NormalizedCacheObject,
+  type NormalizedCacheObject,
   ObservableQuery,
-  ApolloQueryResult,
-  WatchQueryOptions,
+  type ApolloQueryResult,
+  type WatchQueryOptions,
 } from '@apollo/client';
 
 async function maybeWarmUpCache<TQuery, TVariables>(
   watchQuery: ObservableQuery<TQuery, TVariables>,
   queryFn: () => Promise<ApolloQueryResult<TQuery>>
 ) {
-  watchQuery.result().then(results => {
+  watchQuery.result().then((results) => {
     /**
      * partial indicates that no all query data has been fetched
      * which shows that there wasn't server call, or something went wrong

packages/gene-apollo/src/apollo/transformApolloResponse.ts

@@ -1,4 +1,4 @@
-import { ApolloQueryResult, QueryResult } from '@apollo/client';
+import type { ApolloQueryResult, QueryResult } from '@apollo/client';
 import { CommonServiceType } from '@brainly-gene/core';
 
 export function transformApolloResponse<TData = null, TVariables = null>(

packages/gene-apollo/src/apollo/useApolloLazyQuery.spec.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import {
   mockFetch,
   mockFetchBasedOnQuery,

packages/gene-apollo/src/apollo/useApolloLazyQuery.ts

@@ -1,14 +1,11 @@
 import React from 'react';
 import {
   ApolloClient,
-  ApolloQueryResult,
-  NormalizedCacheObject,
+  type ApolloQueryResult,
+  type NormalizedCacheObject,
 } from '@apollo/client';
 import { transformApolloResponse } from './transformApolloResponse';
-import {
-  CommonFetchFn,
-  CommonServiceType,
-} from '@brainly-gene/core';
+import { CommonFetchFn, CommonServiceType } from '@brainly-gene/core';
 
 interface PropsType<TData, TVariables> {
   apolloClient: ApolloClient<NormalizedCacheObject>;
@@ -28,12 +25,8 @@ export function useApolloLazyQuery<TData, TVariables = Record<string, any>>({
 
   const fetch: CommonFetchFn<TData, TVariables> = React.useCallback(
     async (options) => {
-      const {
-        variables,
-        optimisticResponse,
-        refetchQueries,
-        updates,
-      } = options || {};
+      const { variables, optimisticResponse, refetchQueries, updates } =
+        options || {};
       try {
         if (optimisticResponse) {
           setQueryResults({

packages/gene-apollo/src/apollo/useApolloObservableQuery.spec.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import { renderHook, waitFor } from '@testing-library/react';
 import { useApolloObservableQuery } from './useApolloObservableQuery';
 

packages/gene-apollo/src/apollo/useApolloObservableQuery.ts

@@ -1,18 +1,21 @@
-import { ApolloQueryResult, ObservableQuery } from '@apollo/client';
+import {
+  type ApolloQueryResult,
+  ObservableQuery,
+  type FetchMoreQueryOptions,
+  type FetchMoreOptions,
+} from '@apollo/client';
 
 import { transformApolloResponse } from './transformApolloResponse';
 import { merge } from 'zen-observable/extras';
 import { Observable } from 'zen-observable-ts';
-import { isServer } from '@brainly-gene/core';
-import { FetchMoreQueryOptions, FetchMoreOptions } from '@apollo/client';
-
 import {
+  isServer,
   ROUTER_SERVICE_IDENTIFIER,
   RouterEvent,
   RouterIocType,
+  useObservableQuery,
+  useInjection,
 } from '@brainly-gene/core';
-import { useObservableQuery } from '@brainly-gene/core';
-import { useInjection } from '@brainly-gene/core';
 
 /**
  *

packages/gene-apollo/src/apollo/useInjectedApollo.ts

@@ -1,7 +1,5 @@
-import { ApolloClient, NormalizedCacheObject } from '@apollo/client';
-import { Factory } from '@brainly-gene/core';
-import { useInjection } from '@brainly-gene/core';
-import { ServiceTypes } from '@brainly-gene/core';
+import { ApolloClient, type NormalizedCacheObject } from '@apollo/client';
+import { Factory, useInjection, ServiceTypes } from '@brainly-gene/core';
 
 export function useInjectedApolloClient() {
   try {

packages/gene-next/src/api-routes/apiHandlerConnect.ts

@@ -1,4 +1,4 @@
-import nc, {NextConnect, Options} from 'next-connect';
+import nc, {type NextConnect, type Options} from 'next-connect';
 import {NextApiRequest, NextApiResponse} from 'next';
 import {IncomingMessage, ServerResponse} from 'http';
 

packages/gene-next/src/image-assets/components/NextImage.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import Image from 'next/image';
 import { GeneImagePropsType } from '@brainly-gene/core';
 

packages/gene-next/src/image-assets/components/NextImageImgproxyLoader.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import Image, { ImageLoaderProps, ImageProps } from 'next/image';
 import { GeneImagePropsType } from '@brainly-gene/core';
 

packages/gene-tools/src/checkers/component-report/mocks/components/AllowedMocks.spec.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import {render} from '@testing-library/react';
 import CmpsList from './NotApplyListSpecCoverage';
 

packages/gene-tools/src/checkers/component-report/mocks/components/AllowedMocks.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 const CmpsList = ({cmps}) => {
   return <div />;

packages/gene-tools/src/checkers/component-report/mocks/components/AllowedProps.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 import cx from 'classnames';
 

packages/gene-tools/src/checkers/component-report/mocks/components/CallbackProp.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/CallbackPropPrivate.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/ExternalTypeDispatch.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import {dispatch} from '@brainly-gene/core';
 import {ExampleOnClickType, ExampleEventsType} from '@acme/example';
 

packages/gene-tools/src/checkers/component-report/mocks/components/FunctionDeclaration.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/FunctionProp.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/InlineArrowFunc.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/InlineObject.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/InvalidConditionalRender.stories.tsx

@@ -1,6 +1,6 @@
 import {ValidConditionalRenderEventsType} from './ValidConditionalRenderEventsType';
 
-import * as React from 'react';
+import React from 'react';
 import {storiesOf} from '@storybook/react';
 import {registerStoryInPackages, StorybookMediator} from '@brainly-gene/core';
 import ValidConditionalRender from './ValidConditionalRender';

packages/gene-tools/src/checkers/component-report/mocks/components/InvalidConditionalRender.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   firstName?: string;

packages/gene-tools/src/checkers/component-report/mocks/components/InvalidDispatch.stories.tsx

@@ -1,6 +1,6 @@
 import {ValidDispatchEventsType} from './ValidDispatchEventsType';
 
-import * as React from 'react';
+import React from 'react';
 import {storiesOf} from '@storybook/react';
 import {registerStoryInPackages, StorybookMediator} from '@brainly-gene/core';
 import InvalidDispatch from './InvalidDispatch';

packages/gene-tools/src/checkers/component-report/mocks/components/InvalidDispatch.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import {dispatch} from '@brainly-gene/core';
 
 type PropsType = Readonly<{

packages/gene-tools/src/checkers/component-report/mocks/components/InvalidPropsForwardRef.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/MissingDispatch.stories.tsx

@@ -1,6 +1,6 @@
 import {MissingDispatchEventsType} from './MissingDispatchEventsType';
 
-import * as React from 'react';
+import React from 'react';
 import {storiesOf} from '@storybook/react';
 import {registerStoryInPackages, StorybookMediator} from '@brainly-gene/core';
 

packages/gene-tools/src/checkers/component-report/mocks/components/MissingDispatch.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 const MissingDispatch = () => {
   return null;

packages/gene-tools/src/checkers/component-report/mocks/components/MissingListSpecCoverage.spec.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import {render} from '@testing-library/react';
 import CmpsList from './PassingListSpecCoverage';
 

packages/gene-tools/src/checkers/component-report/mocks/components/MissingListSpecCoverage.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 const CmpsList = ({cmps}) => {
   const items = cmps.map(() => <div />);

packages/gene-tools/src/checkers/component-report/mocks/components/MissingListStories.stories.tsx

@@ -1,6 +1,6 @@
 import {ValidDispatchEventsType} from './ValidDispatchEventsType';
 
-import * as React from 'react';
+import React from 'react';
 import {storiesOf} from '@storybook/react';
 import {registerStoryInPackages, StorybookMediator} from '@brainly-gene/core';
 import MissingListStories from './MissingListStories';

packages/gene-tools/src/checkers/component-report/mocks/components/MissingListStories.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   text?: string;

packages/gene-tools/src/checkers/component-report/mocks/components/NoDefaultExport.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/NoMemo.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = Readonly<{
   id: string;

packages/gene-tools/src/checkers/component-report/mocks/components/NoMocks.spec.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 import {render} from '@testing-library/react';
 import CmpsList from './NotApplyListSpecCoverage';
 

packages/gene-tools/src/checkers/component-report/mocks/components/NoMocks.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 const CmpsList = ({cmps}) => {
   return <div />;

packages/gene-tools/src/checkers/component-report/mocks/components/NoProps.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 const NoProps = () => {
   return null;

packages/gene-tools/src/checkers/component-report/mocks/components/NoReadonlyProps.tsx

@@ -1,4 +1,4 @@
-import * as React from 'react';
+import React from 'react';
 
 type PropsType = {
   id: string;