allow symfony 4 or higher, use phpunit 9.5, raise minimum php version to 7.4, remove sensiolabs insight

timonf · timonf · commit d0d32322fca1 · 2021-10-12T17:08:00.000+02:00
diff --git a/.travis.yml b/.travis.yml
@@ -1,7 +1,8 @@
 language: php
 
 php:
-  - 7.1
+  - 7.4
+  - 8.0
   - nightly
 
 matrix:
diff --git a/README.md b/README.md
@@ -1,7 +1,6 @@
 Transcoder Library
 ==================
 
-[![SensioLabsInsight](https://insight.sensiolabs.com/projects/101113a8-06da-4547-aae8-cc9c77027c5b/mini.png)](https://insight.sensiolabs.com/projects/101113a8-06da-4547-aae8-cc9c77027c5b)
 [![Build Status](https://travis-ci.org/brainbits/transcoder.png?branch=master)](https://travis-ci.org/brainbits/transcoder)
 [![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/brainbits/transcoder/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/brainbits/transcoder/?branch=master)
 [![Scrutinizer Code Coverage](https://scrutinizer-ci.com/g/brainbits/transcoder/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/brainbits/transcoder/?branch=master)
diff --git a/composer.json b/composer.json
@@ -19,12 +19,13 @@
         }
     ],
     "require": {
-        "php": "^7.1",
+        "php": ">=7.4",
         "psr/log": "^1.0",
-        "symfony/process": "^2.8|^3.0"
+        "symfony/process": ">=4.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^6.0"
+        "phpunit/phpunit": "^9.5",
+        "phpspec/prophecy-phpunit": "^2.0"
     },
     "autoload": {
         "psr-4": { "Brainbits\\Transcoder\\": "src/" }
diff --git a/src/Decoder/SevenzDecoder.php b/src/Decoder/SevenzDecoder.php
@@ -15,7 +15,6 @@
 
 use Brainbits\Transcoder\Exception\DecodeFailedException;
 use Symfony\Component\Process\Process;
-use Symfony\Component\Process\ProcessBuilder;
 
 /**
  * 7z decoder.
@@ -57,11 +56,11 @@ public function supports(?string $type): bool
 
     private function getProcess(string $data): Process
     {
-        $processBuilder = new ProcessBuilder(
+        $process = new Process(
             [$this->executable, 'e', '-si', '-so', '-an', '-txz', '-m0=lzma2', '-mx=9', '-mfb=64', '-md=32m']
         );
-        $processBuilder->setInput($data);
+        $process->setInput($data);
 
-        return $processBuilder->getProcess();
+        return $process;
     }
 }
diff --git a/src/Encoder/SevenzEncoder.php b/src/Encoder/SevenzEncoder.php
@@ -15,7 +15,6 @@
 
 use Brainbits\Transcoder\Exception\EncodeFailedException;
 use Symfony\Component\Process\Process;
-use Symfony\Component\Process\ProcessBuilder;
 
 /**
  * 7z encoder.
@@ -57,11 +56,11 @@ public function supports(?string $type): bool
 
     private function getProcess(string $data): Process
     {
-        $processBuilder = new ProcessBuilder(
+        $process = new Process(
             [$this->executable, 'a', '-si', '-so', '-an', '-txz', '-m0=lzma2', '-mx=9', '-mfb=64', '-md=32m']
         );
-        $processBuilder->setInput($data);
+        $process->setInput($data);
 
-        return $processBuilder->getProcess();
+        return $process;
     }
 }
diff --git a/tests/Decoder/Bzip2DecoderTest.php b/tests/Decoder/Bzip2DecoderTest.php
@@ -25,12 +25,12 @@ class Bzip2DecoderTest extends TestCase
       */
     private $decoder;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->decoder = new Bzip2Decoder();
     }
 
-    public function testDecode()
+    public function testDecode(): void
     {
         $testString    = 'a string to be decompressed';
         $encodedString = bzcompress($testString);
@@ -40,7 +40,7 @@ public function testDecode()
         $this->assertSame($testString, $result);
     }
 
-    public function testDecodeThrowsErrorOnEmptyResult()
+    public function testDecodeThrowsErrorOnEmptyResult(): void
     {
         $this->expectException(DecodeFailedException::class);
 
@@ -52,7 +52,7 @@ public function testDecodeThrowsErrorOnEmptyResult()
         $this->assertSame($testString, $result);
     }
 
-    public function testDecodeError()
+    public function testDecodeError(): void
     {
         $this->expectException(DecodeFailedException::class);
 
@@ -61,7 +61,7 @@ public function testDecodeError()
         $this->decoder->decode($testString);
     }
 
-    public function testSupports()
+    public function testSupports(): void
     {
         $this->assertTrue($this->decoder->supports('bzip2'));
         $this->assertFalse($this->decoder->supports('foo'));
diff --git a/tests/Decoder/DecoderResolverTest.php b/tests/Decoder/DecoderResolverTest.php
@@ -15,6 +15,7 @@
 use Brainbits\Transcoder\Decoder\DecoderResolver;
 use Brainbits\Transcoder\Tests\TranscoderTestHelper;
 use PHPUnit\Framework\TestCase;
+use Prophecy\PhpUnit\ProphecyTrait;
 use Prophecy\Prophecy\ObjectProphecy;
 use RuntimeException;
 
@@ -23,12 +24,13 @@
  */
 class DecoderResolverTest extends TestCase
 {
+    use ProphecyTrait;
     use TranscoderTestHelper;
 
     /**
      * @expectedException RuntimeException
      */
-    public function testResolveThrowsRuntimeExceptionWithoutDecoders()
+    public function testResolveThrowsRuntimeExceptionWithoutDecoders(): void
     {
         $this->expectException(RuntimeException::class);
 
@@ -37,11 +39,10 @@ public function testResolveThrowsRuntimeExceptionWithoutDecoders()
         $resolver->resolve('test');
     }
 
-    /**
-     * @expectedException RuntimeException
-     */
-    public function testResolveRuntimeExceptionWithoutMatchingDecoder()
+    public function testResolveRuntimeExceptionWithoutMatchingDecoder(): void
     {
+        $this->expectException(RuntimeException::class);
+
         $decoder = $this->prophesizeDecoder();
         $decoder->supports('test')
             ->shouldBeCalled()
@@ -52,7 +53,7 @@ public function testResolveRuntimeExceptionWithoutMatchingDecoder()
         $resolver->resolve('test');
     }
 
-    public function testResolveReturnsCorrectDecoder()
+    public function testResolveReturnsCorrectDecoder(): void
     {
         $decoder = $this->prophesizeDecoder();
         $decoder->supports('test')
diff --git a/tests/Decoder/DeflateDecoderTest.php b/tests/Decoder/DeflateDecoderTest.php
@@ -25,12 +25,12 @@ class DeflateDecoderTest extends TestCase
       */
     private $decoder;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->decoder = new DeflateDecoder();
     }
 
-    public function testDecode()
+    public function testDecode(): void
     {
         $testString    = 'a string to be decompressed';
         $encodedString = gzdeflate($testString);
@@ -40,7 +40,7 @@ public function testDecode()
         $this->assertSame($testString, $result);
     }
 
-    public function testDecodeThrowsErrorOnEmptyResult()
+    public function testDecodeThrowsErrorOnEmptyResult(): void
     {
         $this->expectException(DecodeFailedException::class);
 
@@ -52,7 +52,7 @@ public function testDecodeThrowsErrorOnEmptyResult()
         $this->assertSame($testString, $result);
     }
 
-    public function testSupports()
+    public function testSupports(): void
     {
         $this->assertTrue($this->decoder->supports('deflate'));
         $this->assertFalse($this->decoder->supports('foo'));
diff --git a/tests/Decoder/GzipDecoderTest.php b/tests/Decoder/GzipDecoderTest.php
@@ -25,12 +25,12 @@ class GzipDecoderTest extends TestCase
       */
     private $decoder;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->decoder = new GzipDecoder();
     }
 
-    public function testDecode()
+    public function testDecode(): void
     {
         $testString    = 'a string to be decompressed';
         $encodedString = gzencode($testString);
@@ -40,7 +40,7 @@ public function testDecode()
         $this->assertSame($testString, $result);
     }
 
-    public function testDecodeThrowsErrorOnEmptyResult()
+    public function testDecodeThrowsErrorOnEmptyResult(): void
     {
         $this->expectException(DecodeFailedException::class);
 
@@ -52,7 +52,7 @@ public function testDecodeThrowsErrorOnEmptyResult()
         $this->assertSame($testString, $result);
     }
 
-    public function testSupports()
+    public function testSupports(): void
     {
         $this->assertTrue($this->decoder->supports('gzip'));
         $this->assertFalse($this->decoder->supports('foo'));
diff --git a/tests/Decoder/NullDecoderTest.php b/tests/Decoder/NullDecoderTest.php
@@ -24,12 +24,12 @@ class NullDecoderTest extends TestCase
       */
     private $decoder;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->decoder = new NullDecoder();
     }
 
-    public function testDecode()
+    public function testDecode(): void
     {
         $testString = 'a string to be decompressed';
 
@@ -38,7 +38,7 @@ public function testDecode()
         $this->assertSame($testString, $result);
     }
 
-    public function testSupports()
+    public function testSupports(): void
     {
         $this->assertTrue($this->decoder->supports('null'));
         $this->assertTrue($this->decoder->supports(null));
diff --git a/tests/Decoder/SevenzDecoderTest.php b/tests/Decoder/SevenzDecoderTest.php
@@ -20,29 +20,29 @@
  */
 class SevenzDecoderTest extends TestCase
 {
-    public function testEmptyConstructor()
+    public function testEmptyConstructor(): void
     {
         $decoder = new SevenzDecoder();
 
         $this->assertSame('7z', $decoder->getExecutable());
     }
 
-    public function testExecutable()
+    public function testExecutable(): void
     {
         $decoder = new SevenzDecoder('foo');
 
         $this->assertSame('foo', $decoder->getExecutable());
     }
 
-    public function testSupports()
+    public function testSupports(): void
     {
         $decoder = new SevenzDecoder();
 
         $this->assertTrue($decoder->supports('7z'));
         $this->assertFalse($decoder->supports('foo'));
     }
 
-    public function testDecode()
+    public function testDecode(): void
     {
         $rc = null;
         $out = null;
@@ -65,7 +65,7 @@ public function testDecode()
     /**
      * @depends testDecode
      */
-    public function testFail()
+    public function testFail(): void
     {
         $this->expectException(DecodeFailedException::class);
 
diff --git a/tests/Encoder/Bzip2EncoderTest.php b/tests/Encoder/Bzip2EncoderTest.php
@@ -24,7 +24,7 @@ class Bzip2EncoderTest extends TestCase
       */
     private $encoder;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->encoder = new Bzip2Encoder();
     }
diff --git a/tests/Encoder/DeflateEncoderTest.php b/tests/Encoder/DeflateEncoderTest.php
@@ -24,12 +24,12 @@ class DeflateEncoderTest extends TestCase
       */
     private $encoder;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->encoder = new DeflateEncoder();
     }
 
-    public function testEncode()
+    public function testEncode(): void
     {
         $testString = 'a string to be compressed';
 
@@ -40,7 +40,7 @@ public function testEncode()
         $this->assertSame($testString, $uncompressedResult);
     }
 
-    public function testSupports()
+    public function testSupports(): void
     {
         $this->assertTrue($this->encoder->supports('deflate'));
         $this->assertFalse($this->encoder->supports('foo'));
diff --git a/tests/Encoder/EncoderResolverTest.php b/tests/Encoder/EncoderResolverTest.php
@@ -15,16 +15,18 @@
 use Brainbits\Transcoder\Encoder\EncoderResolver;
 use Brainbits\Transcoder\Tests\TranscoderTestHelper;
 use PHPUnit\Framework\TestCase;
+use Prophecy\PhpUnit\ProphecyTrait;
 use RuntimeException;
 
 /**
  * @covers \Brainbits\Transcoder\Encoder\EncoderResolver
  */
 class EncoderResolverTest extends TestCase
 {
+    use ProphecyTrait;
     use TranscoderTestHelper;
 
-    public function testResolveThrowsRuntimeExceptionWithoutDecoders()
+    public function testResolveThrowsRuntimeExceptionWithoutDecoders(): void
     {
         $this->expectException(RuntimeException::class);
 
@@ -33,7 +35,7 @@ public function testResolveThrowsRuntimeExceptionWithoutDecoders()
         $resolver->resolve('test');
     }
 
-    public function testResolveRuntimeExceptionWithoutMatchingDecoder()
+    public function testResolveRuntimeExceptionWithoutMatchingDecoder(): void
     {
         $this->expectException(RuntimeException::class);
 
@@ -47,7 +49,7 @@ public function testResolveRuntimeExceptionWithoutMatchingDecoder()
         $resolver->resolve('test');
     }
 
-    public function testResolveReturnsCorrectDecoder()
+    public function testResolveReturnsCorrectDecoder(): void
     {
         $encoder = $this->prophesizeEncoder();
         $encoder->supports('test')
diff --git a/tests/Encoder/GzipEncoderTest.php b/tests/Encoder/GzipEncoderTest.php
@@ -24,12 +24,12 @@ class GzipEncoderTest extends TestCase
       */
     private $encoder;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->encoder = new GzipEncoder();
     }
 
-    public function testEncode()
+    public function testEncode(): void
     {
         $testString = 'a string to be compressed';
 
@@ -40,7 +40,7 @@ public function testEncode()
         $this->assertSame($testString, $uncompressedResult);
     }
 
-    public function testSupports()
+    public function testSupports(): void
     {
         $this->assertTrue($this->encoder->supports('gzip'));
         $this->assertFalse($this->encoder->supports('foo'));
diff --git a/tests/Encoder/NullEncoderTest.php b/tests/Encoder/NullEncoderTest.php
diff --git a/tests/Encoder/SevenzEncoderTest.php b/tests/Encoder/SevenzEncoderTest.php
diff --git a/tests/TranscoderFactoryTest.php b/tests/TranscoderFactoryTest.php
diff --git a/tests/TranscoderTest.php b/tests/TranscoderTest.php

-Original file line number
+Diff line change
@@ @@ -1,7 +1,8 @@ @@
 language: php
 php:
 -  - 7.1
 +  - 7.4
 +  - 8.0
   - nightly
 matrix:
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`
`16`	`16`	`use Brainbits\Transcoder\Exception\DecodeFailedException;`
`17`	`17`	`use Symfony\Component\Process\Process;`
`18`		`-use Symfony\Component\Process\ProcessBuilder;`
`19`	`18`
`20`	`19`	`/**`
`21`	`20`	`* 7z decoder.`
`@@ -57,11 +56,11 @@ public function supports(?string $type): bool`
`57`	`56`
`58`	`57`	`private function getProcess(string $data): Process`
`59`	`58`	`{`
`60`		`- $processBuilder = new ProcessBuilder(`
	`59`	`+ $process = new Process(`
`61`	`60`	`[$this->executable, 'e', '-si', '-so', '-an', '-txz', '-m0=lzma2', '-mx=9', '-mfb=64', '-md=32m']`
`62`	`61`	`);`
`63`		`- $processBuilder->setInput($data);`
	`62`	`+ $process->setInput($data);`
`64`	`63`
`65`		`- return $processBuilder->getProcess();`
	`64`	`+ return $process;`
`66`	`65`	`}`
`67`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,12 +25,12 @@ class Bzip2DecoderTest extends TestCase`
`25`	`25`	`*/`
`26`	`26`	`private $decoder;`
`27`	`27`
`28`		`- protected function setUp()`
	`28`	`+ protected function setUp(): void`
`29`	`29`	`{`
`30`	`30`	`$this->decoder = new Bzip2Decoder();`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function testDecode()`
	`33`	`+ public function testDecode(): void`
`34`	`34`	`{`
`35`	`35`	`$testString = 'a string to be decompressed';`
`36`	`36`	`$encodedString = bzcompress($testString);`
`@@ -40,7 +40,7 @@ public function testDecode()`
`40`	`40`	`$this->assertSame($testString, $result);`
`41`	`41`	`}`
`42`	`42`
`43`		`- public function testDecodeThrowsErrorOnEmptyResult()`
	`43`	`+ public function testDecodeThrowsErrorOnEmptyResult(): void`
`44`	`44`	`{`
`45`	`45`	`$this->expectException(DecodeFailedException::class);`
`46`	`46`
`@@ -52,7 +52,7 @@ public function testDecodeThrowsErrorOnEmptyResult()`
`52`	`52`	`$this->assertSame($testString, $result);`
`53`	`53`	`}`
`54`	`54`
`55`		`- public function testDecodeError()`
	`55`	`+ public function testDecodeError(): void`
`56`	`56`	`{`
`57`	`57`	`$this->expectException(DecodeFailedException::class);`
`58`	`58`
`@@ -61,7 +61,7 @@ public function testDecodeError()`
`61`	`61`	`$this->decoder->decode($testString);`
`62`	`62`	`}`
`63`	`63`
`64`		`- public function testSupports()`
	`64`	`+ public function testSupports(): void`
`65`	`65`	`{`
`66`	`66`	`$this->assertTrue($this->decoder->supports('bzip2'));`
`67`	`67`	`$this->assertFalse($this->decoder->supports('foo'));`
Original file line number	Diff line number	Diff line change
`@@ -25,12 +25,12 @@ class DeflateDecoderTest extends TestCase`
`25`	`25`	`*/`
`26`	`26`	`private $decoder;`
`27`	`27`
`28`		`- protected function setUp()`
	`28`	`+ protected function setUp(): void`
`29`	`29`	`{`
`30`	`30`	`$this->decoder = new DeflateDecoder();`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function testDecode()`
	`33`	`+ public function testDecode(): void`
`34`	`34`	`{`
`35`	`35`	`$testString = 'a string to be decompressed';`
`36`	`36`	`$encodedString = gzdeflate($testString);`
`@@ -40,7 +40,7 @@ public function testDecode()`
`40`	`40`	`$this->assertSame($testString, $result);`
`41`	`41`	`}`
`42`	`42`
`43`		`- public function testDecodeThrowsErrorOnEmptyResult()`
	`43`	`+ public function testDecodeThrowsErrorOnEmptyResult(): void`
`44`	`44`	`{`
`45`	`45`	`$this->expectException(DecodeFailedException::class);`
`46`	`46`
`@@ -52,7 +52,7 @@ public function testDecodeThrowsErrorOnEmptyResult()`
`52`	`52`	`$this->assertSame($testString, $result);`
`53`	`53`	`}`
`54`	`54`
`55`		`- public function testSupports()`
	`55`	`+ public function testSupports(): void`
`56`	`56`	`{`
`57`	`57`	`$this->assertTrue($this->decoder->supports('deflate'));`
`58`	`58`	`$this->assertFalse($this->decoder->supports('foo'));`
Original file line number	Diff line number	Diff line change
`@@ -25,12 +25,12 @@ class GzipDecoderTest extends TestCase`
`25`	`25`	`*/`
`26`	`26`	`private $decoder;`
`27`	`27`
`28`		`- protected function setUp()`
	`28`	`+ protected function setUp(): void`
`29`	`29`	`{`
`30`	`30`	`$this->decoder = new GzipDecoder();`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function testDecode()`
	`33`	`+ public function testDecode(): void`
`34`	`34`	`{`
`35`	`35`	`$testString = 'a string to be decompressed';`
`36`	`36`	`$encodedString = gzencode($testString);`
`@@ -40,7 +40,7 @@ public function testDecode()`
`40`	`40`	`$this->assertSame($testString, $result);`
`41`	`41`	`}`
`42`	`42`
`43`		`- public function testDecodeThrowsErrorOnEmptyResult()`
	`43`	`+ public function testDecodeThrowsErrorOnEmptyResult(): void`
`44`	`44`	`{`
`45`	`45`	`$this->expectException(DecodeFailedException::class);`
`46`	`46`
`@@ -52,7 +52,7 @@ public function testDecodeThrowsErrorOnEmptyResult()`
`52`	`52`	`$this->assertSame($testString, $result);`
`53`	`53`	`}`
`54`	`54`
`55`		`- public function testSupports()`
	`55`	`+ public function testSupports(): void`
`56`	`56`	`{`
`57`	`57`	`$this->assertTrue($this->decoder->supports('gzip'));`
`58`	`58`	`$this->assertFalse($this->decoder->supports('foo'));`
Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,12 @@ class NullDecoderTest extends TestCase`
`24`	`24`	`*/`
`25`	`25`	`private $decoder;`
`26`	`26`
`27`		`- protected function setUp()`
	`27`	`+ protected function setUp(): void`
`28`	`28`	`{`
`29`	`29`	`$this->decoder = new NullDecoder();`
`30`	`30`	`}`
`31`	`31`
`32`		`- public function testDecode()`
	`32`	`+ public function testDecode(): void`
`33`	`33`	`{`
`34`	`34`	`$testString = 'a string to be decompressed';`
`35`	`35`
`@@ -38,7 +38,7 @@ public function testDecode()`
`38`	`38`	`$this->assertSame($testString, $result);`
`39`	`39`	`}`
`40`	`40`
`41`		`- public function testSupports()`
	`41`	`+ public function testSupports(): void`
`42`	`42`	`{`
`43`	`43`	`$this->assertTrue($this->decoder->supports('null'));`
`44`	`44`	`$this->assertTrue($this->decoder->supports(null));`
Original file line number	Diff line number	Diff line change
`@@ -20,29 +20,29 @@`
`20`	`20`	`*/`
`21`	`21`	`class SevenzDecoderTest extends TestCase`
`22`	`22`	`{`
`23`		`- public function testEmptyConstructor()`
	`23`	`+ public function testEmptyConstructor(): void`
`24`	`24`	`{`
`25`	`25`	`$decoder = new SevenzDecoder();`
`26`	`26`
`27`	`27`	`$this->assertSame('7z', $decoder->getExecutable());`
`28`	`28`	`}`
`29`	`29`
`30`		`- public function testExecutable()`
	`30`	`+ public function testExecutable(): void`
`31`	`31`	`{`
`32`	`32`	`$decoder = new SevenzDecoder('foo');`
`33`	`33`
`34`	`34`	`$this->assertSame('foo', $decoder->getExecutable());`
`35`	`35`	`}`
`36`	`36`
`37`		`- public function testSupports()`
	`37`	`+ public function testSupports(): void`
`38`	`38`	`{`
`39`	`39`	`$decoder = new SevenzDecoder();`
`40`	`40`
`41`	`41`	`$this->assertTrue($decoder->supports('7z'));`
`42`	`42`	`$this->assertFalse($decoder->supports('foo'));`
`43`	`43`	`}`
`44`	`44`
`45`		`- public function testDecode()`
	`45`	`+ public function testDecode(): void`
`46`	`46`	`{`
`47`	`47`	`$rc = null;`
`48`	`48`	`$out = null;`
`@@ -65,7 +65,7 @@ public function testDecode()`
`65`	`65`	`/**`
`66`	`66`	`* @depends testDecode`
`67`	`67`	`*/`
`68`		`- public function testFail()`
	`68`	`+ public function testFail(): void`
`69`	`69`	`{`
`70`	`70`	`$this->expectException(DecodeFailedException::class);`
`71`	`71`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class Bzip2EncoderTest extends TestCase`
`24`	`24`	`*/`
`25`	`25`	`private $encoder;`
`26`	`26`
`27`		`- protected function setUp()`
	`27`	`+ protected function setUp(): void`
`28`	`28`	`{`
`29`	`29`	`$this->encoder = new Bzip2Encoder();`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,12 @@ class DeflateEncoderTest extends TestCase`
`24`	`24`	`*/`
`25`	`25`	`private $encoder;`
`26`	`26`
`27`		`- protected function setUp()`
	`27`	`+ protected function setUp(): void`
`28`	`28`	`{`
`29`	`29`	`$this->encoder = new DeflateEncoder();`
`30`	`30`	`}`
`31`	`31`
`32`		`- public function testEncode()`
	`32`	`+ public function testEncode(): void`
`33`	`33`	`{`
`34`	`34`	`$testString = 'a string to be compressed';`
`35`	`35`
`@@ -40,7 +40,7 @@ public function testEncode()`
`40`	`40`	`$this->assertSame($testString, $uncompressedResult);`
`41`	`41`	`}`
`42`	`42`
`43`		`- public function testSupports()`
	`43`	`+ public function testSupports(): void`
`44`	`44`	`{`
`45`	`45`	`$this->assertTrue($this->encoder->supports('deflate'));`
`46`	`46`	`$this->assertFalse($this->encoder->supports('foo'));`
Original file line number	Diff line number	Diff line change
`@@ -15,16 +15,18 @@`
`15`	`15`	`use Brainbits\Transcoder\Encoder\EncoderResolver;`
`16`	`16`	`use Brainbits\Transcoder\Tests\TranscoderTestHelper;`
`17`	`17`	`use PHPUnit\Framework\TestCase;`
	`18`	`+use Prophecy\PhpUnit\ProphecyTrait;`
`18`	`19`	`use RuntimeException;`
`19`	`20`
`20`	`21`	`/**`
`21`	`22`	`* @covers \Brainbits\Transcoder\Encoder\EncoderResolver`
`22`	`23`	`*/`
`23`	`24`	`class EncoderResolverTest extends TestCase`
`24`	`25`	`{`
	`26`	`+ use ProphecyTrait;`
`25`	`27`	`use TranscoderTestHelper;`
`26`	`28`
`27`		`- public function testResolveThrowsRuntimeExceptionWithoutDecoders()`
	`29`	`+ public function testResolveThrowsRuntimeExceptionWithoutDecoders(): void`
`28`	`30`	`{`
`29`	`31`	`$this->expectException(RuntimeException::class);`
`30`	`32`
`@@ -33,7 +35,7 @@ public function testResolveThrowsRuntimeExceptionWithoutDecoders()`
`33`	`35`	`$resolver->resolve('test');`
`34`	`36`	`}`
`35`	`37`
`36`		`- public function testResolveRuntimeExceptionWithoutMatchingDecoder()`
	`38`	`+ public function testResolveRuntimeExceptionWithoutMatchingDecoder(): void`
`37`	`39`	`{`
`38`	`40`	`$this->expectException(RuntimeException::class);`
`39`	`41`
`@@ -47,7 +49,7 @@ public function testResolveRuntimeExceptionWithoutMatchingDecoder()`
`47`	`49`	`$resolver->resolve('test');`
`48`	`50`	`}`
`49`	`51`
`50`		`- public function testResolveReturnsCorrectDecoder()`
	`52`	`+ public function testResolveReturnsCorrectDecoder(): void`
`51`	`53`	`{`
`52`	`54`	`$encoder = $this->prophesizeEncoder();`
`53`	`55`	`$encoder->supports('test')`