From 92ec4abb61e35ea87e4958a508f46eb0e04bf58f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luis=20Gonz=C3=A1lez?= <lgonzalez@vauxoo.com>
Date: Sat, 27 Jul 2024 01:49:39 +0000
Subject: [PATCH] [FIX] default_warehouse_from_sale_team: remove incorrect
 record rule

There was a rule to grant read-only access to pickings. However, the
correct way to grant read-only access to a model is to uncheck the
"Read" field on the desired rule, which would cause that rule to not be
considered when verifying accesses.
---
 .../security/ir_rule_security.xml                      | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/default_warehouse_from_sale_team/security/ir_rule_security.xml b/default_warehouse_from_sale_team/security/ir_rule_security.xml
index 90677694cdf..eca463da650 100644
--- a/default_warehouse_from_sale_team/security/ir_rule_security.xml
+++ b/default_warehouse_from_sale_team/security/ir_rule_security.xml
@@ -21,17 +21,9 @@
     <record id="rule_default_warehouse_stock_picking_team" model="ir.rule">
         <field name="name">Limited access to pickings (filtered by sale teams)</field>
         <field name="model_id" search="[('model','=','stock.picking')]" model="ir.model" />
-        <field name="domain_force">[
-            ('warehouse_id', 'in', user.sale_team_ids.default_warehouse_id.ids),
-        ]</field>
-        <field name="groups" eval="[Command.set([ref('group_limited_default_warehouse_sp')])]" />
-    </record>
-    <record id="rule_default_warehouse_stock_picking_team12" model="ir.rule">
-        <field name="name">Limited access to pickings (filtered by not in sale teams)</field>
-        <field name="model_id" search="[('model','=','stock.picking')]" model="ir.model" />
         <field name="perm_read" eval="False" />
         <field name="domain_force">[
-            ('warehouse_id', 'not in', user.sale_team_ids.default_warehouse_id.ids),
+            ('warehouse_id', 'in', user.sale_team_ids.default_warehouse_id.ids),
         ]</field>
         <field name="groups" eval="[Command.set([ref('group_limited_default_warehouse_sp')])]" />
     </record>