feat: update code to meet new Ruff linting rules

RUF021 and RUF022 had to be disabled. The latter looks like
it's bugged.

Author: boriel

.pre-commit-config.yaml

@@ -11,7 +11,7 @@ repos:
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
     # Ruff version.
-    rev: v0.4.10
+    rev: v0.9.4
     hooks:
       # Run the linter.
       - id: ruff

pyproject.toml

@@ -153,6 +153,8 @@ ignore = [
     "RUF005",
     "RUF012",
     "RUF013",
+    "RUF021",
+    "RUF022", # isort sorting style is not alphabetical and seems not natural either (despite the doc)
     "UP008",
     "UP015",  # KEEP: redundant-open-modes
     "UP024",

src/api/check.py

@@ -14,24 +14,24 @@
 from src.symbols.symbol_ import Symbol
 from src.symbols.type_ import Type
 
-__all__ = [
-    "check_type",
-    "check_is_declared_explicit",
+__all__ = (
     "check_and_make_label",
-    "check_type_is_explicit",
     "check_call_arguments",
+    "check_is_declared_explicit",
     "check_pending_calls",
     "check_pending_labels",
-    "is_number",
+    "check_type",
+    "check_type_is_explicit",
+    "common_type",
     "is_const",
-    "is_static",
-    "is_string",
-    "is_numeric",
     "is_dynamic",
     "is_null",
+    "is_number",
+    "is_numeric",
+    "is_static",
+    "is_string",
     "is_unsigned",
-    "common_type",
-]
+)
 
 
 # ----------------------------------------------------------------------

src/api/debug.py

@@ -7,7 +7,7 @@
 
 from .config import OPTIONS
 
-__all__ = ["__DEBUG__", "__LINE__", "__FILE__"]
+__all__ = "__DEBUG__", "__FILE__", "__LINE__"
 
 # --------------------- END OF GLOBAL FLAGS ---------------------
 

src/api/errmsg.py

@@ -15,7 +15,13 @@
 from src.api.constants import CLASS
 
 # Exports only these functions. Others
-__all__ = ["error", "is_valid_warning_code", "warning", "warning_not_used", "register_warning"]
+__all__ = (
+    "error",
+    "is_valid_warning_code",
+    "register_warning",
+    "warning",
+    "warning_not_used",
+)
 
 
 WARNING_PREFIX: str = ""  # will be prepended to warning messages

src/api/exception.py

@@ -12,11 +12,11 @@
 
 __all__ = [
     "Error",
-    "InvalidOperatorError",
-    "InvalidLoopError",
-    "InvalidCONSTexpr",
-    "InvalidBuiltinFunctionError",
     "InternalError",
+    "InvalidBuiltinFunctionError",
+    "InvalidCONSTexpr",
+    "InvalidLoopError",
+    "InvalidOperatorError",
     "TempAlreadyFreedError",
 ]
 

src/api/options.py

@@ -14,7 +14,12 @@
 
 from src.api.exception import Error
 
-__all__: Final[tuple[str, ...]] = "Option", "Options", "ANYTYPE", "Action"
+__all__: Final[tuple[str, ...]] = (
+    "ANYTYPE",
+    "Action",
+    "Option",
+    "Options",
+)
 
 
 class ANYTYPE:

src/api/symboltable/symboltable.py

@@ -492,10 +492,10 @@ def declare_variable(self, id_: str, lineno: int, type_, default_value=None, cla
             if entry_.scope == SCOPE.parameter:
                 syntax_error(
                     lineno,
-                    f"Variable '{id_}' already declared as a parameter " f"at {entry_.filename}:{entry_.lineno}",
+                    f"Variable '{id_}' already declared as a parameter at {entry_.filename}:{entry_.lineno}",
                 )
             else:
-                syntax_error(lineno, f"Variable '{id_}' already declared at " f"{entry_.filename}:{entry_.lineno}")
+                syntax_error(lineno, f"Variable '{id_}' already declared at {entry_.filename}:{entry_.lineno}")
             return None
 
         if not self.check_class(id_, class_, lineno, scope=self.current_scope):
@@ -525,7 +525,7 @@ def declare_variable(self, id_: str, lineno: int, type_, default_value=None, cla
         if entry.type_ != type_:
             if not type_.implicit and entry.type_ is not None:
                 syntax_error(
-                    lineno, "'%s' suffix is for type '%s' but it was " "declared as '%s'" % (id_, entry.type_, type_)
+                    lineno, "'%s' suffix is for type '%s' but it was declared as '%s'" % (id_, entry.type_, type_)
                 )
                 return None
 
@@ -575,10 +575,10 @@ def declare_const(self, id_: str, lineno: int, type_, default_value):
             if entry.scope == SCOPE.parameter:
                 syntax_error(
                     lineno,
-                    "Constant '%s' already declared as a parameter " "at %s:%i" % (id_, entry.filename, entry.lineno),
+                    "Constant '%s' already declared as a parameter at %s:%i" % (id_, entry.filename, entry.lineno),
                 )
             else:
-                syntax_error(lineno, "Constant '%s' already declared at " "%s:%i" % (id_, entry.filename, entry.lineno))
+                syntax_error(lineno, "Constant '%s' already declared at %s:%i" % (id_, entry.filename, entry.lineno))
             return None
 
         entry = self.declare_variable(id_, lineno, type_, default_value, class_=CLASS.const)
@@ -600,7 +600,7 @@ def declare_label(self, id_: str, lineno: int) -> symbols.ID | None:
         entry = self.get_entry(id_)
         if entry is not None and entry.declared:
             if entry.is_line_number:
-                syntax_error(lineno, "Duplicated line number '%s'. " "Previous was at %i" % (entry.name, entry.lineno))
+                syntax_error(lineno, "Duplicated line number '%s'. Previous was at %i" % (entry.name, entry.lineno))
             else:
                 syntax_error(lineno, "Label '%s' already declared at line %i" % (id_, entry.lineno))
             return None
@@ -680,23 +680,21 @@ def declare_array(self, id_: str, lineno: int, type_, bounds, default_value=None
         if not entry.declared:
             if entry.callable:
                 syntax_error(
-                    lineno, "Array '%s' must be declared before use. " "First used at line %i" % (id_, entry.lineno)
+                    lineno, "Array '%s' must be declared before use. First used at line %i" % (id_, entry.lineno)
                 )
                 return None
         else:
             if entry.scope == SCOPE.parameter:
-                syntax_error(
-                    lineno, "variable '%s' already declared as a " "parameter at line %i" % (id_, entry.lineno)
-                )
+                syntax_error(lineno, "variable '%s' already declared as a parameter at line %i" % (id_, entry.lineno))
             else:
-                syntax_error(lineno, "variable '%s' already declared at " "line %i" % (id_, entry.lineno))
+                syntax_error(lineno, "variable '%s' already declared at line %i" % (id_, entry.lineno))
             return None
 
         if entry.type_ != self.basic_types[TYPE.unknown] and entry.type_ != type_:
             if not type_.implicit:
                 syntax_error(
                     lineno,
-                    "Array suffix for '%s' is for type '%s' " "but declared as '%s'" % (entry.name, entry.type_, type_),
+                    "Array suffix for '%s' is for type '%s' but declared as '%s'" % (entry.name, entry.type_, type_),
                 )
                 return None
 

src/api/utils.py

@@ -10,13 +10,13 @@
 from src.api import constants, errmsg, global_
 
 __all__ = (
+    "chdir",
+    "first",
     "flatten_list",
     "open_file",
     "read_txt_file",
     "sanitize_filename",
     "timeout",
-    "first",
-    "chdir",
 )
 
 __doc__ = """Utils module contains many helpers for several task,

src/arch/z80/__init__.py

@@ -8,8 +8,7 @@
 from .visitor.translator import Translator
 from .visitor.var_translator import VarTranslator
 
-__all__ = "beep", "FunctionTranslator", "Translator", "VarTranslator"
-
+__all__ = "FunctionTranslator", "Translator", "VarTranslator", "beep"
 
 # -----------------------------------------
 # Arch initialization setup