Skip to content

Conversation

@HalidOdat
Copy link
Member

The compare command now accepts directories as arguments and will automatically use the latest.json file from those directories. This maintains backward compatibility with explicit file paths.

@HalidOdat HalidOdat marked this pull request as ready for review November 22, 2025 18:11
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,747 50,747 0
Passed 47,877 47,877 0
Ignored 2,060 2,060 0
Failed 810 810 0
Panics 0 0 0
Conformance 94.34% 94.34% 0.00%

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.06%. Comparing base (6ddc2b4) to head (30dd939).
⚠️ Report is 605 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4544      +/-   ##
==========================================
+ Coverage   47.24%   57.06%   +9.82%     
==========================================
  Files         476      504      +28     
  Lines       46892    57548   +10656     
==========================================
+ Hits        22154    32842   +10688     
+ Misses      24738    24706      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HalidOdat HalidOdat force-pushed the feature/tester-directory-compare branch from eebfa61 to dcfab66 Compare November 22, 2025 18:50
The compare command now accepts directories as arguments and will
automatically use the latest.json file from those directories.
This maintains backward compatibility with explicit file paths.
@HalidOdat HalidOdat force-pushed the feature/tester-directory-compare branch from dcfab66 to 30dd939 Compare November 24, 2025 17:08
@HalidOdat HalidOdat requested a review from a team November 24, 2025 17:15
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I like the updates to the CONTRIBUTING.md


```shell
# Compare using directories
cargo run --release --bin boa_tester -- compare ./test-results-main ./test-results-feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: it'd be nice to build in some log management functionality to boa_tester one day for managing run logs and results.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: it'd be nice to build in some log management functionality to boa_tester one day for managing run logs and results.

That would be awesome!!! Another thought on top of that, maybe we can have the tester be aware of the git commit it was executed on.

An interactive compare, some like thing:

./tester compare history
   COMMIT  AGE       TITLE                BRANCH (if any)
 B 5535234  1d some feature in main       (main)
   0ab0e0a 10m Implement feature one      (feature/branch)
 > 343453c  3h Fix some important issue   (fix/tsts)
   9599434  1d Some other commit message  (fix/tsts)

B is the base, and the arrow (>) is the branch to compare with.

@HalidOdat HalidOdat added this pull request to the merge queue Nov 25, 2025
Merged via the queue into boa-dev:main with commit 5cbbb72 Nov 25, 2025
18 checks passed
@HalidOdat HalidOdat deleted the feature/tester-directory-compare branch November 25, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants