-
-
Notifications
You must be signed in to change notification settings - Fork 477
Allow tester to compare directories #4544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tester to compare directories #4544
Conversation
Test262 conformance changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4544 +/- ##
==========================================
+ Coverage 47.24% 57.06% +9.82%
==========================================
Files 476 504 +28
Lines 46892 57548 +10656
==========================================
+ Hits 22154 32842 +10688
+ Misses 24738 24706 -32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eebfa61 to
dcfab66
Compare
The compare command now accepts directories as arguments and will automatically use the latest.json file from those directories. This maintains backward compatibility with explicit file paths.
dcfab66 to
30dd939
Compare
nekevss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I like the updates to the CONTRIBUTING.md
|
|
||
| ```shell | ||
| # Compare using directories | ||
| cargo run --release --bin boa_tester -- compare ./test-results-main ./test-results-feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: it'd be nice to build in some log management functionality to boa_tester one day for managing run logs and results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: it'd be nice to build in some log management functionality to boa_tester one day for managing run logs and results.
That would be awesome!!! Another thought on top of that, maybe we can have the tester be aware of the git commit it was executed on.
An interactive compare, some like thing:
./tester compare history
COMMIT AGE TITLE BRANCH (if any)
B 5535234 1d some feature in main (main)
0ab0e0a 10m Implement feature one (feature/branch)
> 343453c 3h Fix some important issue (fix/tsts)
9599434 1d Some other commit message (fix/tsts)
B is the base, and the arrow (>) is the branch to compare with.
The compare command now accepts directories as arguments and will automatically use the
latest.jsonfile from those directories. This maintains backward compatibility with explicit file paths.