diff --git a/TODO.rst b/TODO.rst index a2a7b0a..69e2e25 100644 --- a/TODO.rst +++ b/TODO.rst @@ -1,6 +1,3 @@ -* use chan struct{} instead of chan bool for synchronization. -* there is a leak in verify/* use mmprof to fix it. -* add code coverage for verification. * find a way to add SendHeartbeat() in verify/{client.go,server.go} * logs are commented, wrap them under log flag. * document reserved tags. @@ -17,3 +14,4 @@ * run travis for go1.4, go1.5, go1.6 * try gofast on raspberry-pi. * support snappy compression. +* add code coverage for verification. diff --git a/transport.go b/transport.go index 4655b8e..bc78d11 100644 --- a/transport.go +++ b/transport.go @@ -99,7 +99,7 @@ type Transport struct { aliveat int64 txch chan *txproto rxch chan rxpacket - killch chan bool + killch chan struct{} // memory pools p_strms chan *Stream // for locally initiated streams @@ -140,7 +140,7 @@ func NewTransport(name string, conn Transporter, version Version, config map[str conn: conn, txch: make(chan *txproto, chansize+batchsize), rxch: make(chan rxpacket, chansize), - killch: make(chan bool), + killch: make(chan struct{}), msgpools: make(map[uint64]*sync.Pool),