Fix retrieving AWS credentials from gradle.properties (#45)

* Fix retrieving AWS credentials from gradle.properties
* Fix artifact bucket location
* Update gradle wrapper, plugins and dependencies
* Add example of how to depend on client project

Author: bhavikkumar

build.gradle

@@ -7,8 +7,8 @@ plugins {
 }
 
 ext {
-    awsAccessKeyId = hasProperty('AWS_ACCESS_KEY_ID') ? AWS_ACCESS_KEY_ID :  System.getenv('AWS_ACCESS_KEY_ID')
-    awsSecretAccessKey = hasProperty('AWS_SECRET_ACCESS_KEY') ? AWS_SECRET_ACCESS_KEY :  System.getenv('AWS_SECRET_ACCESS_KEY')
+    awsAccessKeyId = properties.containsKey('AWS_ACCESS_KEY_ID') ? AWS_ACCESS_KEY_ID : System.getenv('AWS_ACCESS_KEY_ID')
+    awsSecretAccessKey = properties.containsKey('AWS_SECRET_ACCESS_KEY') ? AWS_SECRET_ACCESS_KEY : System.getenv('AWS_SECRET_ACCESS_KEY')
 }
 
 travisVersioner {
@@ -32,7 +32,7 @@ allprojects {
         mavenCentral()
         jcenter()
         maven {
-            url "s3://artifact.bravenewcoin.com.s3-website-us-west-2.amazonaws.com/maven/release"
+            url "s3://artifact.bravenewcoin.com/maven/release"
             credentials(AwsCredentials) {
                 accessKey "${awsAccessKeyId}"
                 secretKey "${awsSecretAccessKey}"
@@ -55,7 +55,7 @@ allprojects {
     }
 
     checkstyle {
-        toolVersion '8.19'
+        toolVersion '8.20'
         tasks.withType(Checkstyle) {
             reports {
                 xml.enabled false
@@ -72,11 +72,11 @@ allprojects {
     }
 
     dependencies {
-        testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter', version: '5.4.1'
+        testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter', version: '5.4.2'
         testImplementation group: 'org.assertj', name: 'assertj-core', version: '3.12.2'
-        testImplementation group: 'org.mockito', name: 'mockito-core', version: '2.26.0'
-        testImplementation group: 'org.mockito', name: 'mockito-junit-jupiter', version: '2.26.0'
-        testRuntime group: 'org.junit.platform', name: 'junit-platform-launcher', version: '1.4.1'
+        testImplementation group: 'org.mockito', name: 'mockito-core', version: '2.27.0'
+        testImplementation group: 'org.mockito', name: 'mockito-junit-jupiter', version: '2.27.0'
+        testRuntime group: 'org.junit.platform', name: 'junit-platform-launcher', version: '1.4.2'
     }
 }
 

gradle/wrapper/gradle-wrapper.jar

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-5.3.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,21 @@
 #!/usr/bin/env sh
 
+#
+# Copyright 2015 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 ##############################################################################
 ##
 ##  Gradle start up script for UN*X
@@ -28,7 +44,7 @@ APP_NAME="Gradle"
 APP_BASE_NAME=`basename "$0"`
 
 # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-DEFAULT_JVM_OPTS=""
+DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
 
 # Use the maximum available, or set MAX_FD != -1 to use that value.
 MAX_FD="maximum"

gradlew

@@ -1,3 +1,19 @@
+@rem
+@rem Copyright 2015 the original author or authors.
+@rem
+@rem Licensed under the Apache License, Version 2.0 (the "License");
+@rem you may not use this file except in compliance with the License.
+@rem You may obtain a copy of the License at
+@rem
+@rem      http://www.apache.org/licenses/LICENSE-2.0
+@rem
+@rem Unless required by applicable law or agreed to in writing, software
+@rem distributed under the License is distributed on an "AS IS" BASIS,
+@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+@rem See the License for the specific language governing permissions and
+@rem limitations under the License.
+@rem
+
 @if "%DEBUG%" == "" @echo off
 @rem ##########################################################################
 @rem
@@ -14,7 +30,7 @@ set APP_BASE_NAME=%~n0
 set APP_HOME=%DIRNAME%
 
 @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-set DEFAULT_JVM_OPTS=
+set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m"
 
 @rem Find java.exe
 if defined JAVA_HOME goto findJavaFromJavaHome

gradlew.bat

@@ -43,6 +43,7 @@ dependencyManagement {
 }
 
 dependencies {
+    implementation project(':client')
     implementation group: 'org.springframework.boot', name: 'spring-boot-starter-web'
     implementation group: 'org.springframework.boot', name: 'spring-boot-starter-actuator'
     implementation group: 'org.springframework.cloud', name: 'spring-cloud-starter-sleuth'