Skip to content

Commit 4a7885d

Browse files
committed
rxrpc: uninitialized variable in rxrpc_send_ack_packet()
jira LE-1907 Rebuild_History Non-Buildable kernel-5.14.0-284.30.1.el9_2 commit-author Dan Carpenter <[email protected]> commit 3846189 The "pkt" was supposed to have been deleted in a previous patch. It leads to an uninitialized variable bug. Fixes: 72f0c6f ("rxrpc: Allocate ACK records at proposal and queue for transmission") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: David Howells <[email protected]> Signed-off-by: David S. Miller <[email protected]> (cherry picked from commit 3846189) Signed-off-by: Jonathan Maple <[email protected]>
1 parent 2ef9625 commit 4a7885d

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

net/rxrpc/output.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ static void rxrpc_cancel_rtt_probe(struct rxrpc_call *call,
208208
static int rxrpc_send_ack_packet(struct rxrpc_local *local, struct rxrpc_txbuf *txb)
209209
{
210210
struct rxrpc_connection *conn;
211-
struct rxrpc_ack_buffer *pkt;
212211
struct rxrpc_call *call = txb->call;
213212
struct msghdr msg;
214213
struct kvec iov[1];
@@ -276,7 +275,6 @@ static int rxrpc_send_ack_packet(struct rxrpc_local *local, struct rxrpc_txbuf *
276275
rxrpc_set_keepalive(call);
277276
}
278277

279-
kfree(pkt);
280278
return ret;
281279
}
282280

0 commit comments

Comments
 (0)