FIX: Remove unused .as_mut_ptr() on the Array trait

bluss · bluss · commit 6bb14060910e · 2018-12-01T12:23:14.000+01:00
Raw pointer taking should go through the MaybeUninit wrappers around the
arrays anyway, when it is partially uninitialized, which it often is.

The remaining .as_ptr() and .as_slice() methods on Array is only used
on a fully initialized array in ArrayString::from_byte_string
diff --git a/src/array.rs b/src/array.rs
@@ -23,8 +23,6 @@ pub unsafe trait Array {
     #[doc(hidden)]
     fn as_ptr(&self) -> *const Self::Item;
     #[doc(hidden)]
-    fn as_mut_ptr(&mut self) -> *mut Self::Item;
-    #[doc(hidden)]
     fn capacity() -> usize;
 }
 
@@ -99,9 +97,6 @@ macro_rules! fix_array_impl {
             fn as_ptr(&self) -> *const T { self as *const _ as *const _ }
             #[doc(hidden)]
             #[inline(always)]
-            fn as_mut_ptr(&mut self) -> *mut T { self as *mut _ as *mut _}
-            #[doc(hidden)]
-            #[inline(always)]
             fn capacity() -> usize { $len }
         }
     )

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,6 @@ pub unsafe trait Array {`
`23`	`23`	`#[doc(hidden)]`
`24`	`24`	`fn as_ptr(&self) -> *const Self::Item;`
`25`	`25`	`#[doc(hidden)]`
`26`		`- fn as_mut_ptr(&mut self) -> *mut Self::Item;`
`27`		`- #[doc(hidden)]`
`28`	`26`	`fn capacity() -> usize;`
`29`	`27`	`}`
`30`	`28`
`@@ -99,9 +97,6 @@ macro_rules! fix_array_impl {`
`99`	`97`	`fn as_ptr(&self) -> const T { self as const _ as *const _ }`
`100`	`98`	`#[doc(hidden)]`
`101`	`99`	`#[inline(always)]`
`102`		`- fn as_mut_ptr(&mut self) -> mut T { self as mut _ as *mut _}`
`103`		`- #[doc(hidden)]`
`104`		`- #[inline(always)]`
`105`	`100`	`fn capacity() -> usize { $len }`
`106`	`101`	`}`
`107`	`102`	`)`