Screen not always waking up from Suspend if loginctl not C1

[llelectronics]

Our script for bringing the screen back on only checks for C1 session.
However some users might be on another like C2 or so.

loginctl -p Name show-session c1 | cut -d '=' -f 2

[star-buck]

Lets forget C2, we decided to not target C2 as device after testing.

…

On Jun 5, 2018 04:51, "Leszek Lesner" ***@***.***> wrote: Our script for bringing the screen back on only checks for C1 session. However some users might be on another like C2 or so. *loginctl -p Name show-session c1 | cut -d '=' -f 2* — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#143>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAzRhinxx-gONYAi31BOZ9xqC7-NIKYtks5t5nDEgaJpZM4UarBH> .

[shadeslayer]

I think you're confusing the ODROID C2 and systemd's naming of sessions.

[llelectronics]

The issue is about user login sessions and not devices.
We try to grab the correct user name from the loginctl session c1 all the time. Though the normal user might not be using c1 login session but instead another like c2, c3 or something like this.

[star-buck]

Ah okay, then forget my comment :)

…

On Jun 5, 2018 07:35, "Leszek Lesner" ***@***.***> wrote: The issue is about user login sessions and not devices. We try to grab the correct user name from the loginctl session c1 all the time. Though the normal user might not be using c1 login session but instead another like c2, c3 or something like this. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#143 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAzRhukyLGd8NGu3TfIxL5SC-cKJsMWXks5t5pc7gaJpZM4UarBH> .

[adriaandegroot]

netrunner-pinebook/netrunner-pinebook-desktop-settings#1

[shadeslayer]

That looks pretty complex for something that might be far more easily achieved with a systemd user session.

[adriaandegroot]

The original issue was "this script we use is fragile". The PR fixes the script, it doesn't switch to different technologies or a different solution domain.

I can simplify the script to drop sorting and other heuristics, picking the first active session with a seat, that will drop the awk. But you're always going to have to do three things with this script approach:

• find an active session
• find the user name of that session
• do something with loginctl on that session
  Throw in some logging, and it's got some basic complexity youi're not going to lose.

[adriaandegroot]

PR updated, but this is otherwise outside my purview.