Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use an npx and uvx shim with hermit for MCPs #655

Merged
merged 6 commits into from
Jan 21, 2025
Merged

use an npx and uvx shim with hermit for MCPs #655

merged 6 commits into from
Jan 21, 2025

Conversation

michaelneale
Copy link
Collaborator

@michaelneale michaelneale commented Jan 20, 2025 •
edited
Loading

this uses hermit to just in time install node (ie npx) in an isolated way to ensure MCPs that use npx can work

This allows optional variables:

export GOOSE_NPM_REGISTRY= point to a custom registry for MCPs
export GOOSE_NPM_CERT= url to .pem for CA for the custom registry
export GOOSE_UV_REGISTRY= custom UV/pip registry for "UVX" to use
export GOOSE_UV_CERT= url to .pem for CA for the custom registry

@michaelneale michaelneale requested a review from baxen January 20, 2025 07:13
alexhancock
alexhancock approved these changes Jan 20, 2025
View reviewed changes
@michaelneale
adding UV
63dde3e
@michaelneale
Merge branch 'v1.0' into micn/hermitize-npx-mcp
05eb0c7 
* v1.0:
  refactor: use the reuseable bundle-desktop workflow in ci.yml (#658)
  feat: setup tokenizer on the provider model config (#656)
  fix: clean up providers (#650)
salman1993
salman1993 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@salman1993 salman1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!!! 🎉

@michaelneale
parametrise based on config
6686713
@michaelneale
Merge branch 'v1.0' into micn/hermitize-npx-mcp
fd6fec7 
* v1.0:
  fix: add missing type param, separate block for signed/unsigned (#661)
  feat: adds default tools that can use MCP resources (#619)
@michaelneale michaelneale changed the title use an npx shim and hermit for MCPs use an npx and uvx shim with hermit for MCPs Jan 21, 2025
@michaelneale michaelneale merged commit 582b5e4 into v1.0 Jan 21, 2025
4 checks passed
@michaelneale michaelneale deleted the micn/hermitize-npx-mcp branch January 21, 2025 01:29
michaelneale added a commit that referenced this pull request Jan 21, 2025
@michaelneale
Merge branch 'v1.0' into formatting-and-popover
c49889a 
* v1.0:
  use an npx and uvx shim with hermit for MCPs (#655)
  fix: add missing type param, separate block for signed/unsigned (#661)
  feat: adds default tools that can use MCP resources (#619)
acekyd pushed a commit that referenced this pull request Jan 21, 2025
@michaelneale @acekyd
use an npx and uvx shim with hermit for MCPs (#655)
550b456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhancock alexhancock alexhancock approved these changes

@salman1993 salman1993 salman1993 approved these changes

@baxen baxen Awaiting requested review from baxen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelneale @alexhancock @salman1993