Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui][v1] added dropdown icon to directory text to match figma (small) #652

Conversation

tiensi
Copy link
Contributor

@tiensi tiensi commented Jan 19, 2025

Summary
Updated the directory display text to match figma designs 1

Before After
Before After

Footnotes

  1. First time contributing to open source in a while, please feel free to provide any feedback.

@tiensi tiensi marked this pull request as ready for review January 19, 2025 20:17
@tiensi tiensi changed the title [ui] added dropdown icon to directory text to match figma [ui][v1] added dropdown icon to directory text to match figma (small) Jan 19, 2025
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@tiensi tiensi force-pushed the vhuang/ui-add-chevron-to-directory-display-text branch from 6cd512a to cf16941 Compare January 22, 2025 17:53
@tiensi
Copy link
Contributor Author

tiensi commented Jan 22, 2025

Rebased with v1.0

@tiensi tiensi requested a review from michaelneale January 22, 2025 17:54
@tiensi tiensi force-pushed the vhuang/ui-add-chevron-to-directory-display-text branch from cf16941 to 51d3c00 Compare January 22, 2025 20:28
@tiensi
Copy link
Contributor Author

tiensi commented Feb 1, 2025

No longer relevant, closing

@tiensi tiensi closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants