Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up providers #650

Merged
merged 3 commits into from
Jan 20, 2025
Merged

fix: clean up providers #650

merged 3 commits into from
Jan 20, 2025

Conversation

baxen
Copy link
Collaborator

@baxen baxen commented Jan 19, 2025

  1. Pulls message conversion utils into format module
  2. Overhauls the provider tests which were flakey in CI
  3. Removes moderation references for now, as we are investigating how to bring them in without the false positives
  4. Removes cost tracking, as we don't want to keep up to date with the pricing details. We will track tokens instead

@baxen
fix: clean up providers
cde8c01 
0. Pulls message conversion utils into format module
1. Overhauls the provider tests which were flakey in CI
2. Removes moderation references for now, as we are investigating how to
   bring them in without the false positives
3. Removes cost tracking, as we don't want to keep up to date with the
   pricing details. We will track tokens instead
@baxen baxen force-pushed the baxen/provider-flakes branch 3 times, most recently from c9b2b96 to 324501b Compare January 19, 2025 21:33
@baxen
speed up tests
5a547f1 
it was nice to have ollama testing the format as an integration
in CI, but those are covered well by unit tests already and this
increased test times significantly
@baxen baxen force-pushed the baxen/provider-flakes branch from 324501b to 5a547f1 Compare January 20, 2025 00:05
@baxen baxen force-pushed the baxen/provider-flakes branch from c69d4c4 to f05e05f Compare January 20, 2025 02:08
@michaelneale
Copy link
Collaborator

looks good - but a bit big to review in one go - can we get a summary? (not sure where anthropic message formatting goes to for example?)

@michaelneale
Copy link
Collaborator

ah I see - in a formats module but github didn't render the lines of code

salman1993
salman1993 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@salman1993 salman1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! tested this out with openai, databricks, ollama. i wasn't able to test out the anthropic code path - need a key

@salman1993 salman1993 mentioned this pull request Jan 20, 2025
Merged
@baxen baxen merged commit f8a577c into v1.0 Jan 20, 2025
4 checks passed
salman1993 added a commit that referenced this pull request Jan 20, 2025
@salman1993
Merge remote-tracking branch 'origin/v1.0' into sm/init-tokenizer
e1d4aae 
* origin/v1.0:
  fix: clean up providers (#650)
michaelneale added a commit that referenced this pull request Jan 20, 2025
@michaelneale
Merge branch 'v1.0' into micn/hermitize-npx-mcp
05eb0c7 
* v1.0:
  refactor: use the reuseable bundle-desktop workflow in ci.yml (#658)
  feat: setup tokenizer on the provider model config (#656)
  fix: clean up providers (#650)
acekyd pushed a commit that referenced this pull request Jan 21, 2025
@baxen @acekyd
fix: clean up providers (#650)
7d0f74d
@yingjiehe-xyz yingjiehe-xyz deleted the baxen/provider-flakes branch February 5, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salman1993 salman1993 salman1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baxen @michaelneale @salman1993