fix: patch host config handling #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ollama and databricks need host configured and stored
salman1993
reviewed
Jan 19, 2025
| // Although we don't need host to be stored secretly, we use the keyring to make | ||
| // it easier to coordinate with configuration. We could consider a non secret storage tool | ||
| // elsewhere in the future | ||
| let host = crate::key_manager::get_keyring_secret("DATABRICKS_HOST", Default::default())?; | ||
| let model_name = std::env::var("DATABRICKS_MODEL") | ||
| .unwrap_or_else(|_| DATABRICKS_DEFAULT_MODEL.to_string()); |
There was a problem hiding this comment.
not related to this PR - DATABRICKS_DEFAULT_MODEL = "claude-3-5-sonnet-2" won't map to a valid endpoint for everyone
salman1993
approved these changes
Jan 19, 2025
acekyd
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Salman Mohammed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ollama and databricks need host configured and stored