Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release devtools opening keyboard shortcut when goose window is not focused #614

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

alexhancock
Copy link
Collaborator

Releases the devtools opening keyboard shortcut (Alt+Command+I) when goose window is not focused. This makes it so it works for Chrome when not focusing on the Goose app.

Copy link

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@lily-de
Copy link
Collaborator

lily-de commented Jan 15, 2025

I also took a crack at fixing this -- #544

i think your approach is better but maybe consider if we want to turn off dev tools for prod? I actually like having them but I know Mic was thinking we should axe them in the prod version of the desktop app

Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! @lily-de we could use this instead of the other change, I think this is ok

@alexhancock alexhancock merged commit a8bdd5b into v1.0 Jan 15, 2025
6 checks passed
@alexhancock alexhancock deleted the alexhancock/devtools-key-combo branch January 15, 2025 21:22
salman1993 added a commit that referenced this pull request Jan 16, 2025
* origin/v1.0:
  feat: add a truncating agent (#579)
  feat: Release devtools opening keyboard shortcut when goose window is not focused (#614)
  feat: performance tweaks for partial release (#611)
  Alexhancock/inline code (#612)
  feat: add more tracing logs, trim loaded prompt  (#603)
  feature: new welcome page and real keychain  (#604)
  fix: model names in UI API key warning (#609)
  feat: map non-ok responses from provider to human readable error msgs (#610)
  fix: update BufReader capacity to 2MB (#605)
  fix: escape double quotes in error part (#602)
  refactor: remove unused errors in mcp-client (#598)
  add more context from mcp server errors (#599)
  fix: error formatting for vercel data format (#597)
  feat: Add endpoint to store secrets in keychain (#595)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants