[v1.0, chore, ui] close processes when window closes

ui/desktop/src/ChatWindow.tsx

@@ -43,7 +43,7 @@
   chats,
   setChats,
   selectedChatId,
   setSelectedChatId,
   initialQuery,
   setProgressMessage,
   setWorking,
@@ -124,7 +124,7 @@
       c.id === selectedChatId ? { ...c, messages } : c
     );
     setChats(updatedChats);
   }, [messages, selectedChatId]);
 
   const initialQueryAppended = useRef(false);
   useEffect(() => {
@@ -132,7 +132,7 @@
       append({ role: 'user', content: initialQuery });
       initialQueryAppended.current = true;
     }
   }, [initialQuery]);
 
   useEffect(() => {
     if (messages.length > 0) {
@@ -324,7 +324,7 @@
 const addSystemConfig = async (system: string) => {
   console.log("calling add system")
   // Get the app instance from electron
   const app = window.electron.app;
 
   const systemConfig = {
     type: "Stdio",
@@ -421,7 +421,7 @@
 
   // Initialize system config when window loads
   useEffect(() => {
-    addSystemConfig("developer2");
+    addSystemConfig("developer2");        
   }, []);
 
   window.electron.logInfo('ChatWindow loaded');

ui/desktop/src/goosed.ts

@@ -3,6 +3,8 @@ import { createServer } from 'net';
 import os from 'node:os';
 import { getBinaryPath } from './utils/binaryPath';
 import log from './utils/logger';
+import { ChildProcessByStdio } from 'node:child_process';
+import { Readable } from 'node:stream';
 
 // Find an available port to start goosed on
 export const findAvailablePort = (): Promise<number> => {
@@ -58,7 +60,7 @@ const checkServerStatus = async (port: number, maxAttempts: number = 60, interva
   return false;
 };
 
-export const startGoosed = async (app, dir=null, env={}): Promise<[number, string, string]> => {
+export const startGoosed = async (app, dir=null, env={}): Promise<[number, string, ChildProcessByStdio<null, Readable, Readable>]> => {
   // In will use this later to determine if we should start process
   const isDev = process.env.NODE_ENV === 'development';
 
@@ -71,7 +73,7 @@ export const startGoosed = async (app, dir=null, env={}): Promise<[number, strin
   // Skip starting goosed if configured in dev mode
   if (isDev && !app.isPackaged && process.env.VITE_START_EMBEDDED_SERVER === 'no') {
     log.info('Skipping starting goosed in development mode');
-    return [3000, dir, 'dev'];
+    return [3000, dir, null];
   }
 
   // Get the goosed binary path using the shared utility
@@ -130,17 +132,13 @@ export const startGoosed = async (app, dir=null, env={}): Promise<[number, strin
     throw new Error(`Goosed server failed to start on port ${port}`);
   }
 
+
   // Ensure goosed is terminated when the app quits
-  // TODO will need to do it at tab level next
   app.on('will-quit', () => {
     log.info('App quitting, terminating goosed server');
     goosedProcess.kill();
   });
 
-  // Wait for the server to start and fetch the agent version
-  await new Promise(resolve => setTimeout(resolve, 1000)); // Give the server time to start
-  const agentVersion = await fetchAgentVersion(port);
-
   log.info(`Goosed server successfully started on port ${port}`);
-  return [port, dir, agentVersion];
+  return [port, dir, goosedProcess];
 };

ui/desktop/src/main.ts

@@ -129,11 +129,11 @@ const createChat = async (app, query?: string, dir?: string, version?: string) =
     if (checkApiCredentials()) {
       return startGoosed(app, dir);
     } else {
-      return [0, '', ''];
+      return [0, '', null];
     }
   }
 
-  const [port, working_dir, agentVersion] = await maybeStartGoosed();
+  const [port, working_dir, goosedProcess] = await maybeStartGoosed();
 
   const mainWindow = new BrowserWindow({
     titleBarStyle: 'hidden',
@@ -152,7 +152,6 @@ const createChat = async (app, query?: string, dir?: string, version?: string) =
         ...appConfig, 
         GOOSE_SERVER__PORT: port, 
         GOOSE_WORKING_DIR: working_dir,
-        GOOSE_AGENT_VERSION: agentVersion,
         REQUEST_DIR: dir 
       })],
     },
@@ -191,7 +190,11 @@ const createChat = async (app, query?: string, dir?: string, version?: string) =
   windowMap.set(windowId, mainWindow);
   mainWindow.on('closed', () => {
     windowMap.delete(windowId);
+    if (goosedProcess) {
+      goosedProcess?.kill();
+    }
   });
+
 };
 
 const createTray = () => {
@@ -249,6 +252,7 @@ const showWindow = () => {
   });
 };
 
+
 const buildRecentFilesMenu = () => {
   const recentDirs = loadRecentDirs();
   return recentDirs.map(dir => ({