[v1.0, chore, ui] close processes when window closes #584
Conversation
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
ui/desktop/src/main.ts
Outdated
| mainWindow.on('closed', () => { | ||
| windowMap.delete(windowId); | ||
| }); | ||
|
|
||
| mainWindow.on('closed', () => { | ||
| if (goosedProcess) { | ||
| goosedProcess?.kill(); | ||
| } | ||
| }); | ||
|
|
||
| }; |
There was a problem hiding this comment.
why can't this be t same block?
There was a problem hiding this comment.
probably as I was tired abnd missed it!
ui/desktop/src/main.ts
Outdated
| @@ -207,7 +213,6 @@ const createTray = () => { | |||
| const tray = new Tray(iconPath); | |||
|
|
|||
| const contextMenu = Menu.buildFromTemplate([ | |||
| { label: 'Show Window', click: showWindow }, | |||
There was a problem hiding this comment.
Why are we dropping this option. Wouldn't the remaining context menu just have a separator and then the Quit item?
There was a problem hiding this comment.
yeah - but I don't think it did anything? (it was a relic from wing to wing I think?) - but could check that out again
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
|
done in another PR |
cc @Kvadratni @baxen cleaning things up a but with GUI processes