-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interactive after run #1377
Conversation
This adds a flag -s/--interactive that drops into an interactive session after starting from a CLI/file message Also fixed the prompting for tool approvals
3485f75
to
a58abc3
Compare
_ => false, | ||
}; | ||
|
||
let confirmed = cliclack::confirm(prompt).initial_value(true).interact()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this is much cleaner!
} | ||
|
||
/// Start an interactive session, optionally with an initial message | ||
pub async fn interactive(&mut self, message: Option<String>) -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interactive
is a little confusing of a function name because of the argument imo - name something else?
@@ -106,6 +106,14 @@ enum Command { | |||
)] | |||
input_text: Option<String>, | |||
|
|||
/// Continue in interactive mode after processing input | |||
#[arg( | |||
short = 's', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-s
? why not -i
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-i was already taken
This adds a flag -s/--interactive that drops into an interactive session after starting from a CLI/file message