From c812ee6af1acd86cda7ad3a182afbb825c51e93f Mon Sep 17 00:00:00 2001
From: Yingjie He <yingjiehe@squareup.com>
Date: Fri, 21 Feb 2025 14:12:35 -0800
Subject: [PATCH] feat: add default value for openai host (#1336)

---
 ui/desktop/src/components/settings/ProviderSetupModal.tsx   | 6 ++++--
 ui/desktop/src/components/settings/api_keys/utils.tsx       | 1 +
 .../src/components/settings/models/hardcoded_stuff.tsx      | 5 +++++
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/ui/desktop/src/components/settings/ProviderSetupModal.tsx b/ui/desktop/src/components/settings/ProviderSetupModal.tsx
index 29e4204b6..ad643e926 100644
--- a/ui/desktop/src/components/settings/ProviderSetupModal.tsx
+++ b/ui/desktop/src/components/settings/ProviderSetupModal.tsx
@@ -3,7 +3,7 @@ import { Card } from '../ui/card';
 import { Lock } from 'lucide-react';
 import { Input } from '../ui/input';
 import { Button } from '../ui/button';
-import { required_keys } from './models/hardcoded_stuff';
+import { required_keys, default_key_value } from './models/hardcoded_stuff';
 import { isSecretKey } from './api_keys/utils';
 import { OllamaBattleGame } from './OllamaBattleGame';
 
@@ -26,7 +26,9 @@ export function ProviderSetupModal({
   onCancel,
   forceBattle = false,
 }: ProviderSetupModalProps) {
-  const [configValues, setConfigValues] = React.useState<{ [key: string]: string }>({});
+  const [configValues, setConfigValues] = React.useState<{ [key: string]: string }>(
+    default_key_value
+  );
   const requiredKeys = required_keys[provider] || ['API Key'];
   const headerText = title || `Setup ${provider}`;
 
diff --git a/ui/desktop/src/components/settings/api_keys/utils.tsx b/ui/desktop/src/components/settings/api_keys/utils.tsx
index dc8805eb6..74f3776dc 100644
--- a/ui/desktop/src/components/settings/api_keys/utils.tsx
+++ b/ui/desktop/src/components/settings/api_keys/utils.tsx
@@ -6,6 +6,7 @@ export function isSecretKey(keyName: string): boolean {
   const nonSecretKeys = [
     'DATABRICKS_HOST',
     'OLLAMA_HOST',
+    'OPENAI_HOST',
     'AZURE_OPENAI_ENDPOINT',
     'AZURE_OPENAI_DEPLOYMENT_NAME',
   ];
diff --git a/ui/desktop/src/components/settings/models/hardcoded_stuff.tsx b/ui/desktop/src/components/settings/models/hardcoded_stuff.tsx
index 36867007a..b38840153 100644
--- a/ui/desktop/src/components/settings/models/hardcoded_stuff.tsx
+++ b/ui/desktop/src/components/settings/models/hardcoded_stuff.tsx
@@ -75,6 +75,11 @@ export const required_keys = {
   'Azure OpenAI': ['AZURE_OPENAI_API_KEY', 'AZURE_OPENAI_ENDPOINT', 'AZURE_OPENAI_DEPLOYMENT_NAME'],
 };
 
+export const default_key_value = {
+  OPENAI_HOST: 'https://api.openai.com',
+  OLLAMA_HOST: 'localhost',
+};
+
 export const supported_providers = [
   'OpenAI',
   'Anthropic',