Skip to content

Commit

Permalink
fix: temp fix to make CI workflow pass (#970)
Browse files Browse the repository at this point in the history
  • Loading branch information
salman1993 authored Jan 31, 2025
1 parent 8306c4c commit 0020123
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ jobs:
- name: Generate a canary version
id: set-version
run: |
# Something like "1.0.0-canary.<short sha>"
# TODO: fix this to be dynamic - extract version from repo
SHORT_SHA=$(echo "${GITHUB_SHA}" | cut -c1-7)
VERSION="1.0.0-canary.${SHORT_SHA}"
VERSION="1.0.3-canary.${SHORT_SHA}"
echo "version=$VERSION" >> $GITHUB_OUTPUT
# ------------------------------------
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,5 @@ jobs:
uses: ./.github/workflows/bundle-desktop.yml
if: github.event_name == 'pull_request'
with:
version: 1.0.3 # TODO: fix this to be dynamic
signing: false
1 change: 1 addition & 0 deletions .github/workflows/pr-comment-bundle-desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
if: ${{ needs.trigger-on-command.outputs.continue == 'true' }}
uses: ./.github/workflows/bundle-desktop.yml
with:
version: 1.0.3 # TODO: fix this to be dynamic
signing: true
secrets:
CERTIFICATE_OSX_APPLICATION: ${{ secrets.CERTIFICATE_OSX_APPLICATION }}
Expand Down

0 comments on commit 0020123

Please sign in to comment.