Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with mass and sign parsing proforma #72

Open
ypriverol opened this issue Oct 30, 2024 · 1 comment
Open

Error with mass and sign parsing proforma #72

ypriverol opened this issue Oct 30, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ypriverol
Copy link

ypriverol commented Oct 30, 2024 •
edited
Loading

When given a proforma like:

[+56.026215]-K[+70.041865]SAPSIGGVK[-28.0313]K[+56.026215]PHR/3

the masses returned do not contain the sign if they are positive, the returned proforma is:

[56.026215]-K[70.041865]SAPSIGGVK[-28.0313]K[56.026215]PHR/3

Regards
Yasset
@bittremieux bittremieux added bug Something isn't working good first issue Good for newcomers labels Mar 4, 2025
@bittremieux
Copy link
Member

TODO: Make sure that the string conversion of ProForma explicitly includes the sign for mass-modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ypriverol @bittremieux